Skip to content

Adding NewAutoProgress so total can be set. Made Update() thread safe#21

Merged
ldemailly merged 3 commits intomainfrom
expose_auto
Oct 25, 2025
Merged

Adding NewAutoProgress so total can be set. Made Update() thread safe#21
ldemailly merged 3 commits intomainfrom
expose_auto

Conversation

@ldemailly
Copy link
Copy Markdown
Member

No description provided.

@ldemailly ldemailly requested a review from Copilot October 25, 2025 03:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the AutoProgress functionality by adding thread-safe progress updates and explicit return values. The key changes introduce a constructor function for setting the total value upfront and make the Update() method safe for concurrent use.

  • Added NewAutoProgress() constructor to initialize AutoProgress with a total value
  • Made Update() method thread-safe using mutex locks
  • Replaced naked returns with explicit return statements across multiple functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ldemailly ldemailly requested a review from Copilot October 25, 2025 03:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ldemailly ldemailly requested a review from Copilot October 25, 2025 03:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ldemailly ldemailly merged commit 825d32a into main Oct 25, 2025
5 checks passed
@ldemailly ldemailly deleted the expose_auto branch October 25, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants