Conversation
hhhapz
approved these changes
Jul 2, 2024
hhhapz
left a comment
There was a problem hiding this comment.
looks fine, although i would just wait for the docker image to be available before pushing to not require another release once it is.
Member
Author
|
it's taking forever for docker and go-setup to update :/ |
ccoVeille
approved these changes
Jul 2, 2024
Member
Author
Me too but it's been > 5h... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: image finally is there (took 18+h)
Edit: google.golang.org/grpc 1.65.0 forces go 1.21 :/ sigh but... so we get to 1.66.0 - maybe it's better anyway because of build tags etc
I usually rebuild the build image but the base isn't there yet
so using the
toolchaintrick to get the right version