feat(@formatjs/ts-transformer): flatten before id generation, fix #3537#5790
Closed
feat(@formatjs/ts-transformer): flatten before id generation, fix #3537#5790
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
458f3c5 to
24671a1
Compare
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 2, 2026
… (#5790) ### TL;DR Fix issue #3537 by applying message flattening before ID generation in babel-plugin-formatjs. ### What changed? - Added `flatten` option to babel-plugin-formatjs types - Modified `evaluateMessageDescriptor` to apply flattening before calling `overrideIdFn` - Passed the flatten option through the visitor functions - Updated the CLI to leverage the flattening done in the babel plugin instead of applying it afterward - Added tests to verify that flattened messages are correctly passed to `overrideIdFn` ### How to test? 1. Run the new test case: `GH #3537: flatten with overrideIdFn` 2. Verify that when using both `flatten` and `overrideIdFn` options, the ID is generated based on the flattened message 3. Check the CLI integration test for flattening with ID interpolation pattern ### Why make this change? Fixes issue #3537 where message IDs were being generated based on the original message format rather than the flattened version. This caused inconsistencies when using content-based IDs with flattened messages, as the ID was based on the pre-flattened content while the output contained the flattened message. By applying flattening before ID generation, we ensure that the ID is based on the same content that will be in the final output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Fix issue #3537 by applying message flattening before ID generation in babel-plugin-formatjs.
What changed?
flattenoption to babel-plugin-formatjs typesevaluateMessageDescriptorto apply flattening before callingoverrideIdFnoverrideIdFnHow to test?
GH #3537: flatten with overrideIdFnflattenandoverrideIdFnoptions, the ID is generated based on the flattened messageWhy make this change?
Fixes issue #3537 where message IDs were being generated based on the original message format rather than the flattened version. This caused inconsistencies when using content-based IDs with flattened messages, as the ID was based on the pre-flattened content while the output contained the flattened message. By applying flattening before ID generation, we ensure that the ID is based on the same content that will be in the final output.