feat(@formatjs/intl-getcanonicallocales)!: convert to esm#5457
Closed
feat(@formatjs/intl-getcanonicallocales)!: convert to esm#5457
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 14, 2025
7d98a7c to
e6459ea
Compare
3f8d1a4 to
3568809
Compare
3568809 to
9a8d514
Compare
9a8d514 to
7a4a4bd
Compare
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Dec 14, 2025
### TL;DR Convert `intl-getcanonicallocales` package to ESM format. ### What changed? - Added `"type": "module"` to package.json - Updated import paths to include `.js` extensions - Added `exports` field to package.json to define entry points - Removed `main` field from package.json - Added `skip_cjs = True` to the Bazel build configuration ### How to test? 1. Import the package in an ESM environment 2. Verify that all exports work correctly 3. Test the polyfill functionality 4. Run existing tests to ensure functionality is preserved ### Why make this change? This change modernizes the package to use ES Modules format, which is the standard module system for JavaScript. This improves compatibility with modern tooling and bundlers while maintaining the same functionality. The explicit `.js` extensions in import paths and the `exports` field in package.json ensure proper resolution in ESM environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Convert
intl-getcanonicallocalespackage to ESM format.What changed?
"type": "module"to package.json.jsextensionsexportsfield to package.json to define entry pointsmainfield from package.jsonskip_cjs = Trueto the Bazel build configurationHow to test?
Why make this change?
This change modernizes the package to use ES Modules format, which is the standard module system for JavaScript. This improves compatibility with modern tooling and bundlers while maintaining the same functionality. The explicit
.jsextensions in import paths and theexportsfield in package.json ensure proper resolution in ESM environments.