ssa: introduce custom apply stage#1077
Merged
matheuscscp merged 1 commit intomainfrom Jan 21, 2026
Merged
Conversation
Member
Author
|
Supersedes #1073 |
erikgb
reviewed
Jan 19, 2026
erikgb
left a comment
There was a problem hiding this comment.
This looks great, and I am really looking forward to seeing this in a future FluxCD release.
| g, ctx := errgroup.WithContext(ctx) | ||
| g.SetLimit(m.concurrency) | ||
| for i, object := range objects { | ||
| i, object := i, object |
There was a problem hiding this comment.
Is this change unrelated to the purpose of the PR, or have I misunderstood? Maybe do it in a separate PR?
Member
Author
There was a problem hiding this comment.
Gonna leave this comment open for context for future readers
2531bf4 to
012d591
Compare
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
1ef22fc to
8a98478
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This custom stage allows Role and RoleBinding objects to be applied on the same call to
ApplyAllStagedeven if the impersonated ServiceAccount does not have a ClusterRoleBinding for thecluster-adminClusterRole (which bypasses the existence check for the Role on the dry-run of the RoleBinding).