Revert "runtime/secrets: validate proxy URL scheme and length"#1041
Merged
matheuscscp merged 2 commits intomainfrom Oct 9, 2025
Merged
Revert "runtime/secrets: validate proxy URL scheme and length"#1041matheuscscp merged 2 commits intomainfrom
matheuscscp merged 2 commits intomainfrom
Conversation
This reverts commit c1274b1. Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
09073d2 to
c2d48e9
Compare
stefanprodan
approved these changes
Oct 9, 2025
This was referenced Oct 9, 2025
cappyzawa
added a commit
to cappyzawa/pkg
that referenced
this pull request
Dec 3, 2025
Add validation to ProxyURLFromSecret to ensure proxy URLs use supported schemes (http, https, socks5) and do not exceed the maximum length of 2048 characters. This addresses the regression introduced in PR fluxcd#1041 which removed all validation after users reported SOCKS5 proxy breakage. The new implementation properly supports SOCKS5 while maintaining security through scheme and length validation. Signed-off-by: cappyzawa <cappyzawa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c1274b1.
This commit caused a regression in proxy features where we support the SOCKS5 protocol:
fluxcd/source-controller#1915
This protocol is documented as supported, e.g. here:
https://fluxcd.io/flux/components/source/gitrepositories/#proxy-secret-reference