Skip to content

Conversation

@thomhurst
Copy link
Contributor

Support TUnit - #2757

@github-actions
Copy link

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@ITaluone
Copy link
Contributor

The PR template is not meant to be deleted ;)

If would have done so, you probably notice the missing release notes :D

@thomhurst
Copy link
Contributor Author

@ITaluone I don't see a section for 6.12.1Permalink but there's a section on the site. Do I need to re-add that?

@ITaluone
Copy link
Contributor

Hmm it seems that an upmerge from develop to master is necessary. For now you can leave it as is, I suppose, because the upmerge is a pretty big undertaking...

@thomhurst
Copy link
Contributor Author

Anything else I need to progress this?

@dennisdoomen
Copy link
Member

Anything else I need to progress this?

Given our limited free time, our focus is currently on finishing the breaking changes in v7, so we have something to release soon. Everything else gets a lower priority. But as soon as this is off our table, we'll switch back to reviewing and accepting contributions.

@eNeRGy164
Copy link
Contributor

It probably doesn't help that Nick Chapsas called for FluentAssertions-support for TUnit in his latest video. 😛

thomhurst and others added 2 commits September 24, 2024 18:53
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Sep 24, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

(settings, v) => settings
.SetProjectFile(v.project)
.SetFramework(v.framework)
.SetProcessArgumentConfigurator(args => args
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TUnit is built on top of the newer Testing platform instead of VSTest. This means that VSTest CLI args aren't the same, so I needed to create a new target that uses different flags.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also contribute this new testing platform's arguments to Nuke itself, if you want to ;)

Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also requires changes to the read-me, releases.md, about.md, index.html and the core .csproj

@thomhurst
Copy link
Contributor Author

This PR also requires changes to the read-me, releases.md, about.md, index.html and the core .csproj

This branch didn't have the latest release notes etc in. I asked further up, but was told to leave it. Is that resolved now? Or do you want me to grab the latest release notes off the website and add them in?

@dennisdoomen
Copy link
Member

This branch didn't have the latest release notes etc in. I asked further up, but was told to leave it. Is that resolved now? Or do you want me to grab the latest release notes off the website and add them in?

You're targeting develop, so it's going to be part of v7.

@IT-VBFK
Copy link
Contributor

IT-VBFK commented Sep 29, 2024

You're targeting develop, so it's going to be part of v7.

To add this cleanly, we have to upmerge from master (and fix all conflicts accordingly), because develop is way outdated since #2733

@dennisdoomen
Copy link
Member

To add this cleanly, we have to upmerge from master (and fix all conflicts accordingly), because develop is way outdated since #2733

We're going to discard-merge those changes since they are already on develop

@IT-VBFK
Copy link
Contributor

IT-VBFK commented Oct 1, 2024

We're going to discard-merge those changes since they are already on develop

Ah? Didn't know about this in git. How do you do that? I suppose git branch -f master develop isn't correct here 🤔

@dennisdoomen
Copy link
Member

Ah? Didn't know about this in git. How do you do that? I suppose git branch -f master develop isn't correct here

You create a branch from develop, and then do a git merge master -x ours. This essentially tells git to create a merge commit, but ignore the changes that you are merging in.

@IT-VBFK
Copy link
Contributor

IT-VBFK commented Oct 1, 2024

That's cool, learned something new today 🎉

@ITaluone
Copy link
Contributor

ITaluone commented Oct 2, 2024

git merge master -x ours This essentially tells git to create a merge commit, but ignore the changes that you are merging in.

Actually, this ignores only changes (meaning take what the current branch has), when a merge conflict happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: New test framework support - TUnit

8 participants