-
Notifications
You must be signed in to change notification settings - Fork 731
TUnit Framework Support #2758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUnit Framework Support #2758
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
|
The PR template is not meant to be deleted ;) If would have done so, you probably notice the missing release notes :D |
|
Hmm it seems that an upmerge from develop to master is necessary. For now you can leave it as is, I suppose, because the upmerge is a pretty big undertaking... |
|
Anything else I need to progress this? |
Given our limited free time, our focus is currently on finishing the breaking changes in v7, so we have something to release soon. Everything else gets a lower priority. But as soon as this is off our table, we'll switch back to reviewing and accepting contributions. |
|
It probably doesn't help that Nick Chapsas called for FluentAssertions-support for TUnit in his latest video. 😛 |
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
| (settings, v) => settings | ||
| .SetProjectFile(v.project) | ||
| .SetFramework(v.framework) | ||
| .SetProcessArgumentConfigurator(args => args |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TUnit is built on top of the newer Testing platform instead of VSTest. This means that VSTest CLI args aren't the same, so I needed to create a new target that uses different flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also contribute this new testing platform's arguments to Nuke itself, if you want to ;)
dennisdoomen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR also requires changes to the read-me, releases.md, about.md, index.html and the core .csproj
This branch didn't have the latest release notes etc in. I asked further up, but was told to leave it. Is that resolved now? Or do you want me to grab the latest release notes off the website and add them in? |
You're targeting |
To add this cleanly, we have to upmerge from master (and fix all conflicts accordingly), because |
We're going to discard-merge those changes since they are already on |
Ah? Didn't know about this in git. How do you do that? I suppose |
You create a branch from |
|
That's cool, learned something new today 🎉 |
Actually, this ignores only changes (meaning take what the current branch has), when a merge conflict happens. |
Support TUnit - #2757