Skip to content

Add scoped value formatters #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 5 commits into from
Jul 8, 2024
Merged

Add scoped value formatters #2676

jnyrup merged 5 commits into from
Jul 8, 2024

Conversation

@ITaluone
Copy link
Contributor

@ITaluone ITaluone commented Jun 18, 2024 •
edited
Loading

Closes: #2478

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9565943493

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12103
Relevant Lines: 12286
💛 - Coveralls

ITaluone
ITaluone commented Jun 18, 2024
View reviewed changes
@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9566134362

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12103
Relevant Lines: 12286
💛 - Coveralls

ITaluone
ITaluone commented Jun 18, 2024
View reviewed changes
@ITaluone ITaluone mentioned this pull request Jun 19, 2024
Closed
@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch 2 times, most recently from 1082f19 to 9bd75b8 Compare June 20, 2024 07:26
@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9593231468

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12103
Relevant Lines: 12286
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9593346015

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12103
Relevant Lines: 12286
💛 - Coveralls

@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from 9bd75b8 to f929234 Compare June 20, 2024 09:04
@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9594672423

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12100
Relevant Lines: 12283
💛 - Coveralls

IT-VBFK
IT-VBFK reviewed Jun 23, 2024
View reviewed changes
@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from 1e8834b to 50b1f2c Compare June 23, 2024 10:41
@coveralls
Copy link

coveralls commented Jun 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9632815207

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12100
Relevant Lines: 12283
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9632826420

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12100
Relevant Lines: 12283
💛 - Coveralls

dennisdoomen
dennisdoomen requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR. I mostly have minor suggestions that would make the PR even better.

@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from 4cfa82b to 81796df Compare June 25, 2024 20:01
@ITaluone ITaluone requested a review from dennisdoomen June 25, 2024 20:02
@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from 81796df to 6523752 Compare June 25, 2024 20:05
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9668772806

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9664182752: 0.003%
Covered Lines: 12100
Relevant Lines: 12283
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9668821122

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9664182752: 0.003%
Covered Lines: 12100
Relevant Lines: 12283
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9668876071

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9664182752: 0.003%
Covered Lines: 12100
Relevant Lines: 12283
💛 - Coveralls

dennisdoomen
dennisdoomen approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dennisdoomen dennisdoomen requested a review from jnyrup June 26, 2024 05:21
@ITaluone ITaluone mentioned this pull request Jun 26, 2024
Closed
@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from 6523752 to fe217ea Compare June 27, 2024 14:43
@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9698700015

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.677%
Totals Coverage Status
Change from base Build 9698432905: 0.003%
Covered Lines: 12102
Relevant Lines: 12276
💛 - Coveralls

@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from fe217ea to 6bf0046 Compare July 1, 2024 12:44
This was referenced Dec 29, 2025
Merged
Merged
Merged
Closed
Closed
Open
Merged
Open
Open
Open
Open
This was referenced Jan 5, 2026
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Open
Closed
Merged
Open
This was referenced Jan 12, 2026
Open
Closed
Open
Open
Open
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

+1 more reviewer

@IT-VBFK IT-VBFK IT-VBFK left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scoped value formatters

5 participants

@ITaluone @coveralls @dennisdoomen @jnyrup @IT-VBFK