Skip to content

Improve BeUpperCased/BeLowerCased semantics #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 14 commits into from
Jun 10, 2024
Merged

Improve BeUpperCased/BeLowerCased semantics #2660

dennisdoomen merged 14 commits into from
Jun 10, 2024

Conversation

@drewjcooper
Copy link
Contributor

@drewjcooper drewjcooper commented May 27, 2024 •
edited
Loading

The PR changes the semantic of BeUpperCased() and BeLowerCased() in line with the discussion in #2019.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented May 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9439983654

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 97.568%
Totals Coverage Status
Change from base Build 9428450907: 0.002%
Covered Lines: 12063
Relevant Lines: 12247
💛 - Coveralls

@drewjcooper drewjcooper marked this pull request as ready for review May 30, 2024 12:23
dennisdoomen
dennisdoomen requested changes Jun 1, 2024
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work. The basic changes are fine. Now we need to get the docs and naming right.

Also, consider using an IDE that has a spell checker built-in. It'll save you a lot of review comments.

@dennisdoomen dennisdoomen requested a review from jnyrup June 8, 2024 10:58
jnyrup
jnyrup approved these changes Jun 8, 2024
View reviewed changes
@drewjcooper @jnyrup
Apply code review suggestions on comment grammar
5569dcb 
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup
jnyrup reviewed Jun 8, 2024
View reviewed changes
Tests/FluentAssertions.Specs/Primitives/StringAssertionSpecs.BeLowerCased.cs Outdated
// Assert
act.Should().Throw<XunitException>().WithMessage(
"Expected all characters in actual to be lower cased because we want to test the failure message, but found \"ABC\".");
"Expected all alpha characters in actual to be lower cased because we want to test the failure message, but found \"ABC\".");
Copy link
Member

@jnyrup jnyrup Jun 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"alpha" -> "alphabetic" in four tests to make the failing tests pass

Copy link
Contributor Author

@drewjcooper drewjcooper Jun 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! Thought I'd done that. Thanks.
Where can I see that in the build results?

@dennisdoomen dennisdoomen merged commit 59703fe into fluentassertions:develop Jun 10, 2024
@IT-VBFK
Copy link
Contributor

IT-VBFK commented Jun 29, 2024

Breaking change?

@dennisdoomen
Copy link
Member

dennisdoomen commented Jun 29, 2024

Breaking change?

Yes, you're right. I've added the correct label.

This was referenced Jul 21, 2025
Closed
Closed
Closed
This was referenced Dec 30, 2025
Merged
Merged
Closed
Closed
Open
Merged
Open
Open
Open
Closed
This was referenced Jan 6, 2026
Closed
Closed
Closed
Open
Closed
Merged
Closed
Closed
Merged
Open
Open
Open
This was referenced Jan 14, 2026
Closed
Open
Open
Open
Open
Open
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

breaking change enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@drewjcooper @coveralls @IT-VBFK @dennisdoomen @jnyrup