Skip to content

Add missing NotBeIn(DateTimeKind) DateTime assertion #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 7 commits into from
Jan 6, 2024
Merged

Add missing NotBeIn(DateTimeKind) DateTime assertion #2536

dennisdoomen merged 7 commits into from
Jan 6, 2024

Conversation

@IT-VBFK
Copy link
Contributor

@IT-VBFK IT-VBFK commented Jan 5, 2024 •
edited
Loading

Closes #2434

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Jan 5, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Jan 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7432633698

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 97.468%
Totals Coverage Status
Change from base Build 7432082456: 0.002%
Covered Lines: 11760
Relevant Lines: 11944
💛 - Coveralls

@IT-VBFK IT-VBFK changed the title Add missing NotBeIn() DateTimeKind assertion Add missing NotBeIn(DateTimeKind) DateTime assertion Jan 5, 2024
@IT-VBFK IT-VBFK force-pushed the feat/missing_datetime_kind branch from 4a041ad to a37003b Compare January 5, 2024 14:53
jnyrup
jnyrup requested changes Jan 5, 2024
View reviewed changes
@IT-VBFK IT-VBFK force-pushed the feat/missing_datetime_kind branch 2 times, most recently from 832f500 to 837da29 Compare January 5, 2024 21:21
@IT-VBFK IT-VBFK requested a review from jnyrup January 5, 2024 21:22
@IT-VBFK IT-VBFK force-pushed the feat/missing_datetime_kind branch 2 times, most recently from 1341b1c to 7423ca1 Compare January 5, 2024 21:46
dennisdoomen
dennisdoomen reviewed Jan 6, 2024
View reviewed changes
IT-VBFK and others added 4 commits January 6, 2024 15:23
@IT-VBFK @jnyrup
Add missing NotBeIn([DateTimeKind]) assertion
9dc9042 
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
@IT-VBFK
Add documentation
f431d1c
@IT-VBFK @jnyrup
Add release notes
4b58e2c 
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
@IT-VBFK
Accept API changes
73fdb92
@IT-VBFK IT-VBFK force-pushed the feat/missing_datetime_kind branch from 7423ca1 to 73fdb92 Compare January 6, 2024 14:25
@jnyrup jnyrup added the feature label Jan 6, 2024
@IT-VBFK
Copy link
Contributor Author

IT-VBFK commented Jan 6, 2024

I don't get qodana again :D

jnyrup
jnyrup reviewed Jan 6, 2024
View reviewed changes
@IT-VBFK @jnyrup
Update Src/FluentAssertions/Primitives/DateTimeAssertions.cs
9e64265 
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
@jnyrup
Copy link
Member

jnyrup commented Jan 6, 2024

Hmm... the PossibleInvalidOperationException analyzer doesn't seem to take ! into account.
Replacing .Value with .GetValueOrDefault() should silence it then 🤞

Roslyn has a similar analyzer, which can be silenced with !.
https://sharplab.io/#v2:EYLgtghglgdgPgAQEwEYCwAoTyAEBBTAb0x1JwQGYdgB7GgGxwDE6AKAEQgBcBTAFShgeAfhwATAJQ4AvAD5xAOgBqEegFceCgNKwxM6TgAMAbkwkylanUYsaSDt36CR4qXPEBCZao3bd+o1MMMhxzUktaBmY6CgdeASFRSRl5MQUAcR4uFXUeAHkAJ3YeADMINXouVgk/GD1pAxNMAF8gA=

jnyrup
jnyrup reviewed Jan 6, 2024
View reviewed changes
@IT-VBFK @jnyrup
Update DateTimeAssertions.cs
b8d0088 
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
@jnyrup jnyrup requested a review from dennisdoomen January 6, 2024 16:55
@dennisdoomen dennisdoomen merged commit 5b2ff79 into fluentassertions:develop Jan 6, 2024
@IT-VBFK IT-VBFK deleted the feat/missing_datetime_kind branch January 15, 2024 19:21
@dependabot dependabot bot mentioned this pull request Jul 21, 2025
Closed
This was referenced Dec 31, 2025
Closed
Closed
Open
Merged
Open
Open
Open
Closed
Closed
This was referenced Jan 7, 2026
Closed
Closed
Open
Merged
Closed
Merged
Open
Closed
Closed
Merged
Open
Open
Closed
Open
Open
Open
Open
This was referenced Jan 14, 2026
Open
Merged
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add NotBeIn in DateTimeAssertions

4 participants

@IT-VBFK @coveralls @jnyrup @dennisdoomen