Skip to content

Allow fluently calling WithoutMatchingRules and WithoutSelectionRules while using BeEquivalentTo #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 3 commits into from
Nov 14, 2023
Merged

Allow fluently calling WithoutMatchingRules and WithoutSelectionRules while using BeEquivalentTo #2457

dennisdoomen merged 3 commits into from
Nov 14, 2023

Conversation

@vbreuss
Copy link
Contributor

@vbreuss vbreuss commented Nov 12, 2023 •
edited
Loading

Change return type to TSelf for WithoutMatchingRules and WithoutSelectionRules

Fixes #2455

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Nov 12, 2023 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Nov 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6853586581

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 97.457%
Totals Coverage Status
Change from base Build 6843206302: 0.01%
Covered Lines: 11743
Relevant Lines: 11926
💛 - Coveralls

@vbreuss vbreuss changed the title Add fluent syntax for WithoutMatchingRules and WithoutSelectionRules Add fluent syntax for WithoutMatchingRules and WithoutSelectionRules on SelfReferenceEquivalencyOptions<TSelf> Nov 13, 2023
dennisdoomen
dennisdoomen requested changes Nov 13, 2023
View reviewed changes
@vbreuss @dennisdoomen
Update docs/_pages/releases.md
ef6c5b6 
Co-authored-by: Dennis Doomen <dennis.doomen@avivasolutions.nl>
@vbreuss vbreuss changed the title Add fluent syntax for WithoutMatchingRules and WithoutSelectionRules on SelfReferenceEquivalencyOptions<TSelf> Allow fluently calling WithoutMatchingRules and WithoutSelectionRules while using BeEquivalentTo Nov 13, 2023
@dennisdoomen dennisdoomen merged commit f7490a0 into fluentassertions:develop Nov 14, 2023
@vbreuss vbreuss deleted the topic/fix-fluent-syntac branch November 14, 2023 12:34
@ITaluone ITaluone mentioned this pull request Nov 15, 2023
Merged
7 tasks
@jnyrup jnyrup mentioned this pull request Sep 10, 2024
Closed
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 30, 2025
Merged
Merged
Closed
Open
Merged
Open
Open
Open
Open
Closed
This was referenced Jan 7, 2026
Closed
Open
Merged
Closed
Merged
Open
Closed
Closed
Merged
Open
Open
Open
Closed
Open
Open
Open
This was referenced Jan 14, 2026
Open
Merged
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

breaking change enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fluent Syntax for WithoutMatchingRules and WithoutSelectionRules

4 participants

@vbreuss @coveralls @dennisdoomen @jnyrup