Skip to content

Preparing upgrade of analyzers #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 26 commits into from
Mar 8, 2023
Merged

Preparing upgrade of analyzers #2136

jnyrup merged 26 commits into from
Mar 8, 2023

Conversation

@jnyrup
Copy link
Member

@jnyrup jnyrup commented Mar 5, 2023

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

I'm working on migrating our code from the now deprecated Microsoft.CodeAnalysis.FxCopAnalyzers and into .NET analyzers.

This PR focuses on the lowest hanging fruit as the remaining ones might require a discussion about whether we should disable the diagnostics globally or on a case by case basis.

@coveralls
Copy link

coveralls commented Mar 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4336545535

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 54 of 58 (93.1%) changed or added relevant lines in 18 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 97.15%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Src/FluentAssertions/Common/FullFrameworkReflector.cs 0 2 0.0%
Src/FluentAssertions/Execution/DefaultAssertionStrategy.cs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
Src/FluentAssertions/Events/EventRecorder.cs 1 98.21%
Totals Coverage Status
Change from base Build 4332574526: 0.007%
Covered Lines: 12788
Relevant Lines: 13016
💛 - Coveralls

@jnyrup jnyrup requested a review from dennisdoomen March 6, 2023 06:41
dennisdoomen
dennisdoomen reviewed Mar 7, 2023
View reviewed changes
jnyrup added 14 commits March 8, 2023 18:41
@jnyrup
Unnecessary interpolated strings
751cebf
@jnyrup
Use discard parameter names
7b64250
@jnyrup
Use AppendJoin to avoid intermediate string
b604e42
@jnyrup
Compile-time string concatenation
1a2b6c7 
https://sharplab.io/#v2:EYLgxg9gTgpgtADwGwBYA+ABAjABgAQByEAdgMIkDOALgBQCUAsAFADezeHe2+AZhBHgC8eAER8IIgNztOGAOx5xeANSjgAQyhTmAX2bNuecsWr1mbJpzyQTVLrkX8ho8dsuyFS1SI1bpTHSA===
@jnyrup
String operations with constant comparisonType
a6bd17f 
The JIT  can now inline StartsWith and Equals
https://sharplab.io/#v2:EYLgxg9gTgpgtADwGwBYA0AXEBDAzgWwB8ABAJgEYBYAKBuAggBsACAOQgDsBhT3DACmLkADMwBmUbPhispMXAAdsYGAEoaAbxrMdzAMoYoASw4BzHviXHcnZpEvZrnACoBPBTGYBefYZPmIBycOADoAeSgAExNsRgBJUw5oGC48GABubV1iAHZxSWlZaUVlGAB+EINHDFwAdSMMAAt+ACJcVz4YfBCWtDtAqyMbDjcPVW8fQwBXT0JCLN1FnQk5IvklFQqAUQBHKdjcVvbO/F7+oKGXdzUJ5mmMmgBfGjoGFh4OPkERfNW5EpU6moWmoi0gnwwvmMZgsg2G5zhVw83ih/lhjkuoQi0Q4sQSSVgqVwD1B2TyK0K/w25UqGGqdQazTaHQwXR6fXsiJG13GXkmUBmzDmCyWugpMippW2ewORxZXTOnIxw1GNz5dwFJMeQA
@jnyrup
Null coalescing assignment
5570e15
@jnyrup
Make GetConversionOperators private
197ad57
@jnyrup
Target typed new expression
abb8bbf
@jnyrup
Use char overloads of string.Contains
9c982f1
@jnyrup
Exception is always non-null here
48aa590
@jnyrup
Suppress warning about invalid regex
ff665e8
@jnyrup
Simplify Boolean expression
6b91ad1
@jnyrup
Simplify benchmarks code
1f97db2
@jnyrup
Use collection initializer
1412593
jnyrup added 4 commits March 8, 2023 18:48
@jnyrup
Silence CA1508 false positive
469ee76 
The analyzer cannot take multi-threading into account, so it thinks that this.cleanup is *always* non-null inside the if.
dotnet/roslyn-analyzers#1649
@jnyrup
Ensure single enumeration of members
0c63333
@jnyrup
Match parameter name of base type
a8830b8
@jnyrup
Use private protected
087e83a
This was referenced Sep 10, 2025
Open
Closed
Closed
This was referenced Sep 22, 2025
Closed
Closed
Closed
This was referenced Sep 29, 2025
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 13, 2025
Closed
This was referenced Oct 20, 2025
Closed
Closed
Open
Open
This was referenced Oct 27, 2025
Closed
Closed
This was referenced Nov 10, 2025
Closed
Closed
This was referenced Nov 24, 2025
Closed
Open
This was referenced Dec 1, 2025
Closed
Closed
Merged
Closed
This was referenced Dec 22, 2025
Open
Closed
@dependabot dependabot bot mentioned this pull request Jan 1, 2026
Open
This was referenced Jan 11, 2026
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnyrup @coveralls @dennisdoomen