[jruby] avoid using deprecated BigDecimal.new#546
Merged
hsbt merged 1 commit intoruby:masterfrom Oct 18, 2023
Merged
Conversation
Contributor
|
Looking forward to a release of this so we can close the relevant bugs in JRuby: jruby/jruby#7752 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an alternative PR to: #543 - for the
BigDecimalcase it should behave the samemain difference is that a custom
opts[:decimal_class](e.g. aBigDecimalsub-class) should work as before...not sure
decimal_classfeature is used much or that folks would set it to anything different thanBigDecimalbut at least the pure.rb seems to retain a similar logic