Perf. improvements to Hash#to_json in pure implementation generator.#203
Merged
hsbt merged 1 commit intoruby:masterfrom Dec 1, 2023
Merged
Perf. improvements to Hash#to_json in pure implementation generator.#203hsbt merged 1 commit intoruby:masterfrom
hsbt merged 1 commit intoruby:masterfrom
Conversation
- Use `.each` instead of `for` for iterating over elements.
- Initialize `delim`, `result` vars with initial states instead of appending `state.object_nl` later.
- Use faster string interpolation where possible on `Hash#json_transform` instead of appending strings repeatedly.
Benchmark:
```ruby
hash ={:a => {:a => {:a => {:a => {:a => 1}}}}}
require 'benchmark/ips'
Benchmark.ips do |x|
x.report("to_json ") { hash.to_json}
end
```
Before:
Calculating -------------------------------------
to_json 4990 i/100ms
-------------------------------------------------
to_json 52970.8 (±5.9%) i/s - 264470 in 5.010558s
After:
Calculating -------------------------------------
to_json 5253 i/100ms
-------------------------------------------------
to_json 55998.6 (±5.9%) i/s - 283662 in 5.083350s
Member
|
This PR has conflicts. |
Member
|
@vipulnsward Sorry, too late response. I update with the current HEAD and merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perf. improvements to Hash#to_json in pure implementation generator:
.eachinstead offorfor iterating over elements.delim,resultvars with initial states instead of appendingstate.object_nllater.Hash#json_transforminstead of appending strings repeatedly.Benchmark: