Fix Tokenizer onattribend's endIndex#1540
Merged
fb55 merged 4 commits intofb55:masterfrom Jul 16, 2023
Merged
Conversation
Pull Request Test Coverage Report for Build 5535855124
💛 - Coveralls |
Owner
|
Awesome PR, thanks so much @DimaIT! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1538
NoValueattributesendIndexis set to attribute name's end indexendIndexmoved one character forward to match actual attribute endOutput of the script from the ticket:
The fix makes
endIndexconsistent, however I'm a little bit worried that change for quoted attributes may be breaking for someone.