Merged
Conversation
|
No linked issues found. Please add the corresponding issues in the pull request description. |
simoneb
approved these changes
Oct 21, 2024
Collaborator
simoneb
left a comment
There was a problem hiding this comment.
LGTM. Yes, the dist folder is supposed to change because the action needs to be bundled to be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Proposal
This PR adds a new
target-indirectoption, providing the ability to specify semver version for "indirect" dependency type PRs.Motivation
Dependabot PRs come with a
dependency-typemetadata prop which can hold different values includingindirect.target-indirectoption uses the same approach taken with existingtarget-xxxoptions to specifically targetindirectdependency type.target-developmentdirect:developmenttarget-productiondirect:productiontarget-indirectindirectExtra info
"direct:development" Dependabot PRs
Example: https://github.com/toomuchdesign/openapi-ts-json-schema/actions/runs/11336643952/job/31526898957
PR metadata
"direct:production" Dependabot PRs
Example: https://github.com/toomuchdesign/openapi-ts-json-schema/actions/runs/10207116362/job/28241301745
PR metadata
"indirect" Dependabot PRs
Example: https://github.com/toomuchdesign/openapi-ts-json-schema/actions/runs/11336687684/job/31527015545
PR metadata
Extra notes
This feature should be able to provide a solution the Dependabot issue causing
indirectgroup PRs lackingupdate-typemetadata. See: #659A specific test was added to cover such use case.
I'm quite puzzled about the
/distfolder output. Is it expected to be included in PRs?It supports #644 for indirect dependency updates.
Checklist
npm run testandnpm run benchmarkand the Code of conduct