Skip to content

docs(ecosystem): add @yeliex/fastify-problem-details#6546

Merged
Fdawgs merged 2 commits into
fastify:mainfrom
yeliex:codex/add-fastify-problem-details-ecosystem
Mar 6, 2026
Merged

docs(ecosystem): add @yeliex/fastify-problem-details#6546
Fdawgs merged 2 commits into
fastify:mainfrom
yeliex:codex/add-fastify-problem-details-ecosystem

Conversation

@yeliex

@yeliex yeliex commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add @yeliex/fastify-problem-details to the community plugin list in docs/Guides/Ecosystem.md
  • use description: "RFC 9457 Problem Details implementation for Fastify, with typed HTTP errors."
  • keep alphabetical order in the community section

Notes

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Mar 4, 2026
Fdawgs
Fdawgs requested changes Mar 6, 2026
View reviewed changes

@Fdawgs Fdawgs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, the plugin appears to have no tests of any kind. I don't think we can add this in its current state as users can't verify it does what it says on the tin.

@yeliex

yeliex commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Fdawgs Thanks for checking. This plugin does include tests in the monorepo:

  • packages/fastify-problem-details/src/fastify.test.ts
  • packages/fastify-problem-details/src/http-error.test.ts
  • packages/problem-details/src/problem-detail.test.ts
  • packages/problem-details/src/http-error.test.ts
    CI also runs them in .github/workflows/test.yml via pnpm test. If helpful, I can add a dedicated Testing section in the README to make this easier to verify.

Fdawgs
Fdawgs approved these changes Mar 6, 2026
View reviewed changes

@Fdawgs Fdawgs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yeliex, wouldn't have expected them in src/ but there we are!

@Fdawgs Fdawgs merged commit b61c362 into fastify:main Mar 6, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metcoder95 metcoder95 metcoder95 approved these changes

@Fdawgs Fdawgs Fdawgs approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yeliex @metcoder95 @Fdawgs @gurgunday