docs(server): fix camelCase anchor links in TOC#6530
docs(server): fix camelCase anchor links in TOC#6530jean-michelet merged 7 commits intofastify:mainfrom
Conversation
Tony133
left a comment
There was a problem hiding this comment.
The correct method is setGenReqId, not setgenreqid.
Co-authored-by: Antonio Tripodi <Tony133@users.noreply.github.com> Signed-off-by: deepvamja <143236575+Deepvamja@users.noreply.github.com>
Co-authored-by: Antonio Tripodi <Tony133@users.noreply.github.com> Signed-off-by: deepvamja <143236575+Deepvamja@users.noreply.github.com>
|
"Hi, I've addressed all the review comments. Could you please take another look when you get a chance? Thank you!" |
|
"Hi, I've addressed all the review comments. Could you please take another look when you get a chance? Thank you!" |
There was a problem hiding this comment.
Pull request overview
This PR updates the documentation TOC anchors in docs/Reference/Server.md so internal links correctly jump to their sections (fixing broken navigation caused by mismatched anchor casing).
Changes:
- Fix TOC link target for
loggerInstanceto match the generated anchor (#loggerinstance). - Fix TOC link target for
setGenReqIdto match the generated anchor (#setgenreqid). - (Currently) changes the
setGenReqIdsection heading text to lowercase.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the feedback! It looks like the link-check workflow failures are caused by pre-existing links in other documentation files rather than the changes in this PR. This PR only updates the TOC anchors in Server.md. Please let me know if you'd like me to adjust anything further. |
|
Hi @Fdawgs @gurgunday @Tony133! This PR has 3 approvals from maintainers with write access. Could someone merge this when you get a chance? Happy to |
|
Don't think such a doc edit needs additional review, I merge. |
|
@jean-michelet I requested Uzlopak as he made the original PR, so was awaiting his blessing. |
Fixes #6161
The TOC in Server.md contained camelCase anchor links that don't match
markdown's auto-generated lowercase anchors, causing broken navigation.
Changes:
#loggerInstance→#loggerinstance#addHttpMethod→#addhttpmethod#setGenReqId→#setgenreqid