perf: use native WebStream API instead of Readable.fromWeb wrapper#6444
Merged
perf: use native WebStream API instead of Readable.fromWeb wrapper#6444
Conversation
Remove the Node.js stream wrapping overhead by using the WebStream reader API directly. This provides ~21% throughput improvement when returning Response objects or ReadableStreams from route handlers. Changes: - Use reader.getReader() and reader.read() directly - Remove unused Readable import - Add benchmark for WebStream performance testing - Add tests for WebStream error handling paths
4d73ed1 to
450df80
Compare
climba03003
approved these changes
Jan 15, 2026
jsumners
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Responseobjects orReadableStreamfrom route handlersBenchmark Results
Changes
lib/reply.js: RewrotesendWebStream()to usereader.getReader()andreader.read()directly instead ofReadable.fromWeb()examples/benchmark/webstream.js: New benchmark file for WebStream performance testingtest/web-api.test.js: Added tests for error handling paths (stream errors before/after headers sent, headers already sent warning)Test plan