Skip to content

chore: fix type test#6418

Merged
Eomm merged 1 commit intofastify:mainfrom
mrazauskas:fix-type-test
Dec 24, 2025
Merged

chore: fix type test#6418
Eomm merged 1 commit intofastify:mainfrom
mrazauskas:fix-type-test

Conversation

@mrazauskas
Copy link
Contributor

@mrazauskas mrazauskas commented Dec 18, 2025

This is only a tiny change in one of the type tests. I was playing with different testing tools and noticed that this particular test is only passing using tsd (both expect-type and tstyche report an error). After this change, the test is still passing using tsd and the other tools do not report an error anymore. Must be a bug in tsd, because the same test is also passing with negated expectNotType(). These are huge typings, so I will not investigate.

By the way, I bump into this issue while trying out new implementation of TSTyche which does not patch TypeScript any more (reference: #6033 (comment)). It is still fresh and most likely has defects. So far all works very well with fastify type tests.

Checklist

@github-actions github-actions bot added the typescript TypeScript related label Dec 18, 2025
@ilteoood ilteoood self-requested a review December 19, 2025 22:04
@Eomm Eomm merged commit 3897367 into fastify:main Dec 24, 2025
31 checks passed
@mrazauskas mrazauskas deleted the fix-type-test branch December 24, 2025 13:16
@mrazauskas mrazauskas mentioned this pull request Jan 12, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typescript TypeScript related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants