Merged
Conversation
ilteoood
approved these changes
Dec 19, 2025
Eomm
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only a tiny change in one of the type tests. I was playing with different testing tools and noticed that this particular test is only passing using
tsd(bothexpect-typeandtstychereport an error). After this change, the test is still passing usingtsdand the other tools do not report an error anymore. Must be a bug intsd, because the same test is also passing with negatedexpectNotType(). These are huge typings, so I will not investigate.By the way, I bump into this issue while trying out new implementation of TSTyche which does not patch TypeScript any more (reference: #6033 (comment)). It is still fresh and most likely has defects. So far all works very well with
fastifytype tests.Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct