fix: clear [kState].readyPromise for garbage collection#6030
Merged
mcollina merged 1 commit intofastify:mainfrom Mar 30, 2025
Merged
fix: clear [kState].readyPromise for garbage collection#6030mcollina merged 1 commit intofastify:mainfrom
[kState].readyPromise for garbage collection#6030mcollina merged 1 commit intofastify:mainfrom
Conversation
metcoder95
approved these changes
Mar 30, 2025
mcollina
reviewed
Mar 30, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: this is committed with
--no-verifybecause penultimate test fails locally withEAFNOSUPPORT.Checklist
npm run testandnpm run benchmarkand the Code of conduct
Once support of Node.js older than v22.x is dropped, this should probably be rewritten using
Promise.withResolvers().Without the patch,
assert.strictEqualmight hang and timeout instead of failing immediately. Didn't look into it closely, i guess combination of resolved promise and circular references might trigger a bug instrictEqual()?