Skip to content

test: migrated keep-alive-timeout.test.js from tap to node:test#5796

Merged
Uzlopak merged 2 commits into
fastify:mainfrom
Tony133:test/update-keep-alive-timeout-test
Oct 31, 2024
Merged

test: migrated keep-alive-timeout.test.js from tap to node:test#5796
Uzlopak merged 2 commits into
fastify:mainfrom
Tony133:test/update-keep-alive-timeout-test

Conversation

@Tony133

@Tony133 Tony133 commented Oct 30, 2024

Copy link
Copy Markdown
Member

Checklist

Proposal:

  • migrated keepAliveTimeout.test.js file from tap to node:test 🔥

@Tony133 Tony133 force-pushed the test/update-keep-alive-timeout-test branch from 3dd1de3 to 2f4ab99 Compare October 30, 2024 21:55
Comment thread test/keepAliveTimeout.test.js Outdated
@Uzlopak

Uzlopak commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

Please rename file to kebab-case.

@Tony133 Tony133 force-pushed the test/update-keep-alive-timeout-test branch from edad621 to 2f4ab99 Compare October 31, 2024 11:25
@Tony133 Tony133 force-pushed the test/update-keep-alive-timeout-test branch from c28bb5b to 2c5ddf7 Compare October 31, 2024 11:26
@Tony133

Tony133 commented Oct 31, 2024

Copy link
Copy Markdown
Member Author

Please rename file to kebab-case.

Done! see here: https://github.com/fastify/fastify/pull/5796/files

@Tony133 Tony133 changed the title test: migrated keepAliveTimeout.test.js from tap to node:test test: migrated keep-alive-timeout.test.js from tap to node:test Oct 31, 2024

@Uzlopak Uzlopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit 8e00085 into fastify:main Oct 31, 2024
@Tony133 Tony133 deleted the test/update-keep-alive-timeout-test branch October 31, 2024 21:42
@github-actions

github-actions Bot commented Nov 1, 2025

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants