test: port server.test.js to node:test#5783
Conversation
|
|
||
| test('abort signal', t => { | ||
| t.test('listen should not start server', t => { | ||
| describe('abort signal', () => { |
There was a problem hiding this comment.
We don't need to use describe.
| describe('abort signal', () => { | |
| test('abort signal', async () => { |
Also, each subtest should be like:
await t.test('listen should not start server', (t, end) => { end() })There was a problem hiding this comment.
Hey @jsumners, no problem at all, I'm pushing the changes 😁
Could I ask about the rationale behind this choice? 😁
I ask because, IMHO, the describe / test / it approach is cleaner than the await t.test.
There was a problem hiding this comment.
We don't use it anywhere else. And I find it noisy.
There was a problem hiding this comment.
It makes perfect sense, I was just curious 🚀
Thanks for your review!
There was a problem hiding this comment.
pushed the changes in the meantime!
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
server.test.jsporting fromtaptonode:testChecklist
npm run testandnpm run benchmarkand the Code of conduct