feat(test runner node): route 4#5774
Merged
Merged
Conversation
jsumners
reviewed
Oct 26, 2024
jsumners
requested changes
Oct 26, 2024
jsumners
left a comment
Member
There was a problem hiding this comment.
Not clear why blocks are being used.
jsumners
reviewed
Oct 26, 2024
Contributor
Author
|
@jsumners sorry I've pushed to the wrong branch the route 7 test. Can you check also this last test conversion from the last commit when you have some time? A huge thanks! |
jsumners
reviewed
Oct 26, 2024
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ported some test cases to node test runner
Checklist
npm run testandnpm run benchmarkand the Code of conduct