Skip to content

test: move allowUnsafeRegex to node test runner#5770

Merged
mcollina merged 8 commits into
fastify:mainfrom
karankraina:move-node-test
Oct 26, 2024
Merged

test: move allowUnsafeRegex to node test runner#5770
mcollina merged 8 commits into
fastify:mainfrom
karankraina:move-node-test

Conversation

@karankraina

Copy link
Copy Markdown
Contributor

Checklist

@karankraina

Copy link
Copy Markdown
Contributor Author

#5555

Comment thread test/allowUnsafeRegex.test.js Outdated
Comment thread test/buffer.test.js Outdated
Comment thread test/case-insensitive.test.js Outdated
karankraina and others added 4 commits October 26, 2024 08:02
Co-authored-by: Dan Castillo <dan.castillo@jasper.ai>
Signed-off-by: Karan Raina <karanraina1996@gmail.com>
Co-authored-by: Dan Castillo <dan.castillo@jasper.ai>
Signed-off-by: Karan Raina <karanraina1996@gmail.com>
Co-authored-by: Dan Castillo <dan.castillo@jasper.ai>
Signed-off-by: Karan Raina <karanraina1996@gmail.com>
@karankraina

Copy link
Copy Markdown
Contributor Author

@dancastillo Please review new changes too. :)

@jsumners jsumners left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@karankraina

Copy link
Copy Markdown
Contributor Author

@mcollina Can you merge this please

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2ee97ff into fastify:main Oct 26, 2024
@karankraina karankraina deleted the move-node-test branch October 26, 2024 16:14
@github-actions

github-actions Bot commented Nov 1, 2025

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants