fix: exposeHeadRoute should pass "onSend" hook handlers provided to GET handler if method is not uppercased#5766
Merged
Merged
Conversation
Signed-off-by: Aras Abbasi <aras.abbasi@googlemail.com>
4 tasks
climba03003
approved these changes
Oct 24, 2024
metcoder95
approved these changes
Oct 25, 2024
Eomm
approved these changes
Oct 25, 2024
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Signed-off-by: Aras Abbasi <aras.abbasi@googlemail.com>
Contributor
Author
|
@Eomm ptal |
Eomm
approved these changes
Oct 25, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating #5762 I realized that there is an issue when passing lower case methods to the route fn. You could run the test "Will pass onSend hook to HEAD method if exposeHeadRoutes is true /2" on main branch and see that it fails.
Also makes the typings less strict regarding the method attribute as
CONNECTorOPTIONcould be added viaacceptHTTPMethod,Also tries to fail faster.
Requesting review by @climba03003 regarding the exposeHeadRequest logic.
Requesting review by @Eomm regarding the acceptHTTPMethod aspect