fix: correctly handle empty host#5764
Merged
Merged
Conversation
# Conflicts: # lib/request.js
66289b6 to
9abc3b4
Compare
climba03003
reviewed
Oct 24, 2024
climba03003
reviewed
Oct 24, 2024
| // now fall back to port from host/:authority header | ||
| const portFromHeader = parseInt((this.headers.host || this.headers[':authority']).split(':').slice(-1)[0]) | ||
| let host = (this.headers.host ?? this.headers[':authority']) | ||
| if (this.server.server.requireHostHeader === false) host ??= '' |
Member
There was a problem hiding this comment.
Using the http.Server for checking the properties, it is better because it may exists in http, https or http2 options. It should be always the same when we use multiple server instance.
Closed
Eomm
reviewed
Oct 24, 2024
gurgunday
commented
Oct 24, 2024
gurgunday
left a comment
Member
Author
There was a problem hiding this comment.
Nice!
Thanks @climba03003 for taking over, really short on time currently 😄
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I took another look but the original PR seems like the best way to fix this issue
Because node's http server does have a setting to disable the host header requirement, both host and authority can be undefined, and we need to take those configurations into account in Fastify
And if host exists but is empty and authority is undefined (valid request), we should handle that correctly as well