chore: Conditionally require pino if logger is enabled#5763
Merged
Conversation
Contributor
Author
|
@dancastillo Added tests |
metcoder95
reviewed
Oct 24, 2024
Eomm
reviewed
Oct 24, 2024
Eomm
reviewed
Oct 24, 2024
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Signed-off-by: Karan Raina <karanraina1996@gmail.com>
Eomm
reviewed
Oct 24, 2024
Contributor
Author
|
@mcollina @Eomm @metcoder95 An unrelated test is failing. Anyone has any idea? |
Contributor
Author
|
@mcollina @metcoder95 @Eomm I think I found it. It was due this race between 2 |
Contributor
Author
|
Looks like @smartinio already fixed the flaky test on main. Rebased my branch and reverted my changes. |
Eomm
reviewed
Oct 24, 2024
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Signed-off-by: Karan Raina <karanraina1996@gmail.com>
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Signed-off-by: Karan Raina <karanraina1996@gmail.com>
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Signed-off-by: Karan Raina <karanraina1996@gmail.com>
metcoder95
approved these changes
Oct 25, 2024
metcoder95
left a comment
Member
There was a problem hiding this comment.
lgtm, please address @Eomm suggestion
Contributor
Author
|
@Eomm Have done the refactor as per your suggestions. Let me know what you think about this. |
jsumners
requested changes
Oct 25, 2024
Co-authored-by: James Sumners <321201+jsumners@users.noreply.github.com> Signed-off-by: Karan Raina <karanraina1996@gmail.com>
Eomm
reviewed
Oct 25, 2024
Eomm
left a comment
Member
There was a problem hiding this comment.
I think this PR is quite ready! We need just to clean up the code from old trials.
Good work!
jsumners
reviewed
Oct 26, 2024
Co-authored-by: James Sumners <321201+jsumners@users.noreply.github.com> Signed-off-by: Karan Raina <karanraina1996@gmail.com>
…/fastify into conditional-pino-ajv
jsumners
reviewed
Oct 26, 2024
climba03003
approved these changes
Oct 26, 2024
Contributor
Author
|
@jsumners Is this ok to merge now? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
Ref #5507