test: removed second argument from assert fail method in tests#5761
Merged
Uzlopak merged 3 commits intoOct 23, 2024
Merged
Conversation
dancastillo
approved these changes
Oct 23, 2024
climba03003
approved these changes
Oct 23, 2024
Contributor
Author
|
For some reason |
Uzlopak
approved these changes
Oct 23, 2024
1 task
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In my previous PR #5714, I accidentally had one file with
assert.failreceiving two arguments (which is deprecated) instead of one, so I just noticed that and wanted to fix it quickly. I assumed opening a issue for that minor thing is not needed, correct me if I'm wrong.I made sure that the only place that it happened was
./test/https/https.test.js.Checklist
npm run testandnpm run benchmarkand the Code of conduct