docs(reply): cleanup and update to clarify elapsedTime behaviour#5728
Merged
Conversation
…to removed getResponseTime method - Remove incorrect information stating that `elapsedTime` may return zero unless called in the `onResponse` hook. - Remove link to the `.getResponseTime()` method, which was completely removed in version 5.0.0.
climba03003
approved these changes
Oct 7, 2024
|
@climba03003 @mcollina This should be clarified in the documentation or (I think better) made to work without the requirement of onResponse |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor cleanup of Reply docs: Removed incorrect information stating that the elapsedTime getter will return 0 unless called in the onResponse hook, which is not the intended behaviour based on the discussion in #4575 and existing tests. I also removed a link that previously led to the getResponseTime section of the docs before it was removed in v5.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
Cheers!