chore: merge next into main for v5 release by jsumners · Pull Request #5446 · fastify/fastify

jsumners · 2024-05-04T12:34:04Z

For the same reasoning as given in pinojs/pino#1947 (comment), we should just get v5 released.

Important: once this PR is merged in:

We need to create a 4.x branch (actually, do this right before merging)
We need to issue new releases for all of the direct dependencies managed under the Fastify org and then update them in this repo
Should be able to issue the v5 release at this point

I'd say we get the thing out the door and then issue any sort of weblog post (i.e. we shouldn't block on the post being written first).

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

Signed-off-by: Matteo Collina <hello@matteocollina.com>

# Conflicts: # fastify.js # package.json

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

Signed-off-by: KaKa <kaka@kakang.dev> # Conflicts: # docs/Reference/Errors.md # docs/Reference/Server.md # fastify.js # lib/route.js # package.json # test/default-route.test.js # test/types/instance.test-d.ts # test/types/route.test-d.ts

Signed-off-by: KaKa <kaka@kakang.dev> # Conflicts: # fastify.js # package.json

* Disallow `decorate('name', null)` in the types Preferred to use `decorate('name')` , `decorateRequest('name')`, `decorateReply('name')` variants instead Deprecation not feasible because of microsoft/TypeScript#54872 Follow up to #4874 * Docs: Drop `null` from placeholder decorations Signed-off-by: Pelle Wessman <pelle@kodfabrik.se> --------- Signed-off-by: Pelle Wessman <pelle@kodfabrik.se>

Co-authored-by: Carlos Fuentes <me@metcoder.dev>

* add option to disable/ignore request-id header fixes #4192 * add more restrictive schema definition * update configValidator generated by running 'node build/build-validation.js' after change on 'build-validation.js' * move logic into reqIdGenFactory * change default value from requestIdHeader Changes default from 'request-id' to `false`. Making it opt-in instead of opt-out. NOTE: when user sets requestIdHeader to `true` the behavior is the same as if it was set to `false` because `req.headers[true] || genReqId(req)` is equivalent to `genReqId(req)` (req.headers[true] is undefined). TL;DR requestIdHeader must be a string, else it will be 'ignored'. Solution: Provide a default value for requestIdHeader when `true` or throw. * remove comment * adapt --------- Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>

* make FastifySchemaValidationError.params wider (#4476) * fix: FastifySchemaValidationError.params could be unknown * refactor: use FastifySchemaValidationError instead of ValidationResult * fix: export ValidationResult for backword compatibility * test: add non-assignable test for AjvErrorObject * docs(ecosystem): add fastify-hashids (#4934) * fix: hasPlugin does not track parent plugins (#4929) Co-authored-by: Carlos Fuentes <me@metcoder.dev> * docs: early hints plugin is fastify plugin (#4947) * docs: early hints plugin is fastify plugin * fix * Update docs/Guides/Ecosystem.md Co-authored-by: Frazer Smith <frazer.dev@outlook.com> --------- Co-authored-by: Frazer Smith <frazer.dev@outlook.com> * chore: add pull request title check (#4951) * chore: add pull request title check * Update .github/workflows/pull-request-title.yml Co-authored-by: Frazer Smith <frazer.dev@outlook.com> --------- Co-authored-by: Frazer Smith <frazer.dev@outlook.com> * chore: Bump @sinclair/typebox from 0.29.6 to 0.30.2 (#4952) Bumps [@sinclair/typebox](https://github.com/sinclairzx81/typebox) from 0.29.6 to 0.30.2. - [Commits](sinclairzx81/typebox@0.29.6...0.30.2) --- updated-dependencies: - dependency-name: "@sinclair/typebox" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: prove pr title check (#4953) * improve pr title check * Apply suggestions from code review * fix * fix * Update .github/workflows/pull-request-title.yml Co-authored-by: Luis Orbaiceta <luisorbaiceta@gmail.com> * Apply suggestions from code review --------- Co-authored-by: Luis Orbaiceta <luisorbaiceta@gmail.com> * ci: fix warnings in benchmark workflows (#4954) * improve pr title check * Apply suggestions from code review * fix * fix * ci: fix warnings in benchmark workflow * Update .github/workflows/benchmark.yml * Update .github/workflows/benchmark.yml * docs: fix removeAdditional comment (#4948) * docs(Validator Compiler): fix removeAdditional comment * Update docs/Reference/Validation-and-Serialization.md Co-authored-by: Uzlopak <aras.abbasi@googlemail.com> * fix: typo in comment * Update docs/Reference/Validation-and-Serialization.md Co-authored-by: Frazer Smith <frazer.dev@outlook.com> --------- Co-authored-by: Uzlopak <aras.abbasi@googlemail.com> Co-authored-by: Frazer Smith <frazer.dev@outlook.com> * fix: Try to fix parser benchmark workflow (#4956) * fix: infer correct hook handler (#4945) * fix: infer correct hook handler * Update test/types/hooks.test-d.ts * simplify * remove duplicate typing tests * remove duplicate test * remove unused import * fix * fix linting * fix: remove http version check * test: remove unsupported http version * remove obsolete documentation --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: cm-ayf <cm.ayf2734@gmail.com> Co-authored-by: Anderson <andersonjoseph@mailfence.com> Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Co-authored-by: Carlos Fuentes <me@metcoder.dev> Co-authored-by: Uzlopak <aras.abbasi@googlemail.com> Co-authored-by: Frazer Smith <frazer.dev@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Luis Orbaiceta <luisorbaiceta@gmail.com> Co-authored-by: Mohammed Gomaa <midomaxgomaa@gmail.com> Co-authored-by: Igor Savin <iselwin@gmail.com> Co-authored-by: Cem <cembkoztekin@gmail.com>

Co-authored-by: Carlos Fuentes <me@metcoder.dev>

# Conflicts: # fastify.js # lib/warnings.js # package.json # test/default-route.test.js # test/listen.deprecated.test.js # test/serial/logger.0.test.js # test/serial/logger.1.test.js # test/stream.test.js

…5141)

# Conflicts: # docs/Reference/Errors.md # fastify.js # lib/pluginUtils.js # lib/route.js # lib/server.js # lib/warnings.js # package.json # test/default-route.test.js # test/plugin.4.test.js # types/instance.d.ts

# Conflicts: # lib/configValidator.js

.github/workflows/benchmark.yml

.github/workflows/benchmark-parser.yml

mcollina · 2024-05-04T17:33:32Z

I can have time to finalize v5 and issue releases for all the modules in July.

mcollina · 2024-05-04T17:34:08Z

This can land right now and we can start shipping alphas.

jsumners · 2024-05-04T17:35:01Z

Yeah, I can't wait for July. My notifications are already unmanageable and the biggest reason is this ongoing v5 work.

gurgunday · 2024-05-04T18:16:48Z

package.json

    "@fastify/fast-json-stringify-compiler": "^4.3.0",
    "abstract-logging": "^2.0.1",
    "avvio": "^8.3.0",
    "fast-content-type-parse": "^1.1.0",


This is no longer used and should've been removed after #4450

"fast-content-type-parse": "^1.1.0",

Cleaning up of dependencies can happen subsequent to this PR. This PR is about updating main for v5 and is already big enough.

Sure, was just documenting for future reference

gurgunday · 2024-05-04T18:21:44Z

.github/workflows/ci.yml

          - os: macos-latest
            node-version: 16


Not that important but node 14 exclusions were removed so why not also remove 16?

Suggested change

- os: macos-latest

node-version: 16

gurgunday

lgtm

mcollina · 2024-05-04T18:44:23Z

As I said, I don't think I have the time deliver v5 before July. When I shipped v4 it took almost a week of full time work, and I can't simply fit into my calendar before then.

We can ship alphas/rcs before then.

We do need blog post and announcements etc, as it's also a marketing thing.

mcollina · 2024-05-04T18:45:15Z

I plan to issue another v4 release before landing this.

jsumners · 2024-05-04T18:47:39Z

When I shipped v4 it took almost a week of full time work, and I can't simply fit into my calendar before then.

Right. None of us have time for that and really never will. We're just going to have to ship modules as we have time to get to them and/or as people indicate that they need the v5 compatible version.

I'm okay with getting the PR merged and going through alpha releases. At least getting next => main will hopefully allow for getting rid of the backlog of notifications.

Eomm · 2024-05-04T19:00:23Z

We do need blog post and announcements etc, as it's also a marketing thing.

I can draft it 👍🏼

Signed-off-by: Matteo Collina <hello@matteocollina.com>

mcollina · 2024-05-07T13:07:54Z

Landed.

github-actions · 2025-05-08T00:31:58Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

mcollina and others added 30 commits August 19, 2022 12:03

bumped v5.0.0-dev

2c27e70

Signed-off-by: Matteo Collina <hello@matteocollina.com>

Merge branch 'main' into next

db75a3a

# Conflicts: # fastify.js # package.json

Merge branch 'main' into next

580bffa

# Conflicts: # fastify.js # package.json

Merge branch 'main' into next

a4fffa7

add missing route shorthands (#4409)

cd45d4e

Merge branch 'main' into next

c749419

# Conflicts: # fastify.js # package.json

Merge branch 'main' into next

b2fbce0

# Conflicts: # fastify.js # package.json

lib: drop setDefaultRoute and getDefaultRoute methods

b8e201a

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

Merge branch 'main' into next

4a3530f

Signed-off-by: KaKa <kaka@kakang.dev> # Conflicts: # docs/Reference/Errors.md # docs/Reference/Server.md # fastify.js # lib/route.js # package.json # test/default-route.test.js # test/types/instance.test-d.ts # test/types/route.test-d.ts

Merge branch 'main' into next

f3c5c6f

Signed-off-by: KaKa <kaka@kakang.dev> # Conflicts: # fastify.js # package.json

feat!: Add req.hostname and req.port (#4766)

b5172f6

Co-authored-by: Carlos Fuentes <me@metcoder.dev>

Remove deprecated variadic listen (#4900)

c53b75b

Merge branch 'main' into next

f36832f

fix: requestIdHeader docs (#4916)

744d59c

Merge branch 'main' into next

aceab54

Merge branch 'main' into next

f6a87f8

types: remove variadic listen types (#4966)

bcd2eb6

Merge branch 'main' into next

19e3e30

Merge branch 'main' into next

bdf4b54

Merge branch 'main' into next

db5df86

Merge branch 'main' into next

13a8740

Merge branch 'main' into next

74c68ae

feat: new logger api (#5020)

9c63209

Co-authored-by: Carlos Fuentes <me@metcoder.dev>

Merge branch 'main' into next

9270572

# Conflicts: # fastify.js # lib/warnings.js # package.json # test/default-route.test.js # test/listen.deprecated.test.js # test/serial/logger.0.test.js # test/serial/logger.1.test.js # test/stream.test.js

feat(plugins): mixing async and callback style now returns an error (#…

52bbc37

…5141)

Merge branch 'main' into next

fb5b596

# Conflicts: # docs/Reference/Errors.md # fastify.js # lib/pluginUtils.js # lib/route.js # lib/server.js # lib/warnings.js # package.json # test/default-route.test.js # test/plugin.4.test.js # types/instance.d.ts

Merge branch 'main' into next

4064cb5

# Conflicts: # lib/configValidator.js

chore: update node version in workflows

cd8cf86

jsumners force-pushed the next branch from 6489911 to cd8cf86 Compare May 4, 2024 13:45

chore: alt runtimes do not support 22 yet

4a9a344

gurgunday reviewed May 4, 2024

View reviewed changes

.github/workflows/benchmark.yml Show resolved Hide resolved

jsumners marked this pull request as ready for review May 4, 2024 14:20

gurgunday reviewed May 4, 2024

View reviewed changes

.github/workflows/benchmark-parser.yml Show resolved Hide resolved

chore: update benchmark ci

9a6cf27

jsumners force-pushed the next branch from 032d56c to 9a6cf27 Compare May 4, 2024 17:21

jsumners requested review from a team May 4, 2024 17:31

gurgunday reviewed May 4, 2024

View reviewed changes

gurgunday approved these changes May 4, 2024

View reviewed changes

Merge branch 'main' into next

b5891ef

Signed-off-by: Matteo Collina <hello@matteocollina.com>

mcollina merged commit b5891ef into main May 7, 2024

mcollina deleted the next branch May 7, 2024 13:07

lholmquist mentioned this pull request Oct 31, 2024

[Snyk] Upgrade fastify from 4.21.0 to 5.0.0 nodeshift/faas-js-runtime#370

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 8, 2025

Uh oh!

Conversation

jsumners commented May 4, 2024

Checklist

Uh oh!

Uh oh!

Uh oh!

mcollina commented May 4, 2024

Uh oh!

mcollina commented May 4, 2024

Uh oh!

jsumners commented May 4, 2024

Uh oh!

gurgunday May 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsumners May 4, 2024

Choose a reason for hiding this comment

Uh oh!

gurgunday May 4, 2024

Choose a reason for hiding this comment

Uh oh!

gurgunday May 4, 2024

Choose a reason for hiding this comment

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented May 4, 2024

Uh oh!

mcollina commented May 4, 2024

Uh oh!

jsumners commented May 4, 2024

Uh oh!

Eomm commented May 4, 2024

Uh oh!

mcollina commented May 7, 2024

Uh oh!

github-actions bot commented May 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

gurgunday May 4, 2024 •

edited

Loading