Skip to content

feat: disable request logging#5435

Merged
mcollina merged 10 commits intofastify:mainfrom
SamSalvatico:fix/5409-disable-request-logging
May 2, 2024
Merged

feat: disable request logging#5435
mcollina merged 10 commits intofastify:mainfrom
SamSalvatico:fix/5409-disable-request-logging

Conversation

@SamSalvatico
Copy link
Copy Markdown
Contributor

@SamSalvatico SamSalvatico commented Apr 30, 2024 •
edited
Loading

feat for issue: #5409

Check for the disableRequestLogging to be false or undefined before logging an error or a 404 during the request

Checklist

@Uzlopak Uzlopak changed the title Fix: [#5409] disable request logging fix: disable request logging Apr 30, 2024
metcoder95
metcoder95 reviewed May 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Tho, I'm over the fence of considering this as a fix as was never stated that this was supported; I'd rather consider it more an enhancement.

Sadly tests are failing.

@SamSalvatico SamSalvatico changed the title fix: disable request logging feat: disable request logging May 2, 2024
metcoder95
metcoder95 approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@metcoder95
Copy link
Copy Markdown
Member

metcoder95 commented May 2, 2024

Forgot to mention, can we add some documentation of this within the disableRequestLogging option documentation?

mcollina
mcollina approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Uzlopak
Uzlopak approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey ho lets go.

Uzlopak
Uzlopak reviewed May 2, 2024
View reviewed changes
Uzlopak
Uzlopak requested changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit

Uzlopak
Uzlopak approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go

@mcollina mcollina merged commit f2835db into fastify:main May 2, 2024
@SamSalvatico SamSalvatico deleted the fix/5409-disable-request-logging branch May 3, 2024 05:22
@metcoder95 metcoder95 linked an issue May 3, 2024 that may be closed by this pull request
disableRequestLogging should disable logs in default error handler #5409
Closed
2 tasks
@metcoder95 metcoder95 mentioned this pull request May 3, 2024
Closed
2 tasks
@urbankrepel urbankrepel mentioned this pull request May 28, 2024
Merged
@Viorel1989 Viorel1989 mentioned this pull request May 28, 2024
Merged
@raniellimontagna raniellimontagna mentioned this pull request May 28, 2024
Closed
@denbon05 denbon05 mentioned this pull request May 28, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request May 29, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request May 29, 2024
Closed
@JamieVangeysel JamieVangeysel mentioned this pull request Jul 26, 2024
Closed
@JamieVangeysel JamieVangeysel mentioned this pull request Aug 2, 2024
Closed
@NicolasTOISON NicolasTOISON mentioned this pull request Aug 7, 2024
Merged
@JamieVangeysel JamieVangeysel mentioned this pull request Aug 11, 2024
Closed
This was referenced Aug 21, 2024
Open
Open
Open
Open
Open
Open
Open
@Jamesp918 Jamesp918 mentioned this pull request Aug 24, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Aug 25, 2024
Closed
This was referenced Aug 28, 2024
Open
Open
This was referenced Sep 3, 2024
Closed
Closed
This was referenced Sep 8, 2024
Open
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Sep 10, 2024
Closed
@WesleyR10 WesleyR10 mentioned this pull request Sep 12, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Sep 18, 2024
Closed
@Jamesp918 Jamesp918 mentioned this pull request Sep 18, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Sep 24, 2024
Closed
@Jamesp918 Jamesp918 mentioned this pull request Sep 25, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Sep 27, 2024
Closed
@Jamesp918 Jamesp918 mentioned this pull request Oct 15, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Oct 27, 2024
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 4, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

disableRequestLogging should disable logs in default error handler

4 participants

@SamSalvatico @metcoder95 @mcollina @Uzlopak