fix: only run citgm if citgm-core-plugins label is set#5416
Merged
Uzlopak merged 1 commit intofastify:mainfrom Apr 21, 2024
Merged
fix: only run citgm if citgm-core-plugins label is set#5416Uzlopak merged 1 commit intofastify:mainfrom
Uzlopak merged 1 commit intofastify:mainfrom
Conversation
Member
Author
|
Please don't merge unless everything passes |
Member
Author
|
Okay, finally everything looks good |
Uzlopak
approved these changes
Apr 21, 2024
This was referenced May 30, 2024
This was referenced Jun 1, 2024
This was referenced Jun 5, 2024
This was referenced Aug 21, 2024
This was referenced Aug 28, 2024
This was referenced Sep 3, 2024
This was referenced Sep 8, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully the last fix...
Last 2 PRs fixed the benchmark workflow, but CITGM's
remove-labeljob is also always running whenever a label is set and failing because it can't find the label it's trying to remove — it should only run ifcitgm-core-pluginslabel is set to remove that specific label