Skip to content

fix: remove-label job uses the wrong repo#5415

Merged
Uzlopak merged 5 commits intofastify:mainfrom
gurgunday:fix-ending
Apr 21, 2024
Merged

fix: remove-label job uses the wrong repo#5415
Uzlopak merged 5 commits intofastify:mainfrom
gurgunday:fix-ending

Conversation

@gurgunday
Copy link
Copy Markdown
Member

@gurgunday gurgunday commented Apr 21, 2024

Another issue discovered in the CI, remove-label jobs are failing due wrong information being sent to the REST API:

https://github.com/fastify/fastify/actions/runs/8772362238/job/24071203586?pr=5413#step:2:13
https://github.com/fastify/fastify/actions/runs/8772362236/job/24071226346?pr=5413#step:2:13

I believe it's choosing the wrong repo, it should be the base repo instead of the owner of the PR's repo

Reference: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context

@gurgunday gurgunday changed the title Fix ending fix: remove-label uses the wrong repo Apr 21, 2024
@gurgunday gurgunday changed the title fix: remove-label uses the wrong repo fix: remove-label job uses the wrong repo Apr 21, 2024
@gurgunday gurgunday requested review from a team and Uzlopak April 21, 2024 12:08
@Eomm Eomm added the github actions Github actions related label Apr 21, 2024
@gurgunday
Copy link
Copy Markdown
Member Author

@Eomm ok, from 404 - Not found to 403 - Resource not accessible by integration

@gurgunday gurgunday removed the github actions Github actions related label Apr 21, 2024
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess

@gurgunday gurgunday added the github actions Github actions related label Apr 21, 2024
@Uzlopak Uzlopak merged commit c47b033 into fastify:main Apr 21, 2024
@gurgunday gurgunday deleted the fix-ending branch April 21, 2024 15:21
@gurgunday
Copy link
Copy Markdown
Member Author

Why is citgm remove-label still running 🤦

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

github actions Github actions related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants