Skip to content

fix: benchmark CI#5414

Merged
Uzlopak merged 1 commit intofastify:mainfrom
gurgunday:fix-benchmark-ci
Apr 21, 2024
Merged

fix: benchmark CI#5414
Uzlopak merged 1 commit intofastify:mainfrom
gurgunday:fix-benchmark-ci

Conversation

@gurgunday
Copy link
Copy Markdown
Member

@gurgunday gurgunday commented Apr 21, 2024 •
edited
Loading

We cannot only install production dependencies in these workflows as they depend on devDeps to run:

fastify/.github/workflows/benchmark.yml

Line 36 in 13f9b6e

npm install --only=production --ignore-scripts

fastify/.github/workflows/benchmark.yml

Line 41 in 13f9b6e

npm run --silent benchmark > ./bench-result.md

fastify/package.json

Line 10 in 13f9b6e

"benchmark": "concurrently -k -s first \"node ./examples/benchmark/simple.js\" \"autocannon -c 100 -d 30 -p 10 localhost:3000/\"",

fastify/package.json

Lines 155 to 170 in 13f9b6e

"devDependencies": {
"@fastify/pre-commit": "^2.0.2",
"@sinclair/typebox": "^0.31.17",
"@sinonjs/fake-timers": "^11.1.0",
"@types/node": "^20.8.4",
"@typescript-eslint/eslint-plugin": "^6.7.5",
"@typescript-eslint/parser": "^6.7.5",
"ajv": "^8.12.0",
"ajv-errors": "^3.0.0",
"ajv-formats": "^2.1.1",
"ajv-i18n": "^4.2.0",
"ajv-merge-patch": "^5.0.1",
"autocannon": "^7.14.0",
"branch-comparer": "^1.1.0",
"c8": "^8.0.1",
"concurrently": "^8.2.2",

@gurgunday gurgunday requested a review from a team April 21, 2024 09:31
Fdawgs
Fdawgs approved these changes Apr 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot

@Uzlopak Uzlopak merged commit 35a6b99 into fastify:main Apr 21, 2024
@gurgunday gurgunday deleted the fix-benchmark-ci branch April 21, 2024 11:25
@gurgunday gurgunday added the github actions Github actions related label Apr 21, 2024
@urbankrepel urbankrepel mentioned this pull request May 28, 2024
Merged
@Viorel1989 Viorel1989 mentioned this pull request May 28, 2024
Merged
@raniellimontagna raniellimontagna mentioned this pull request May 28, 2024
Closed
@denbon05 denbon05 mentioned this pull request May 28, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request May 29, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request May 29, 2024
Closed
@bryopsida bryopsida mentioned this pull request May 29, 2024
Merged
This was referenced May 30, 2024
Closed
Open
This was referenced Jun 1, 2024
Closed
Closed
@lholmquist lholmquist mentioned this pull request Jun 5, 2024
Closed
This was referenced Jun 5, 2024
Closed
Closed
Closed
@JamieVangeysel JamieVangeysel mentioned this pull request Jun 12, 2024
Closed
@densbozz densbozz mentioned this pull request Jun 13, 2024
Open
@Mykhailo-Sichkaruk Mykhailo-Sichkaruk mentioned this pull request Jun 14, 2024
Closed
@YuraGB YuraGB mentioned this pull request Jun 14, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Jun 14, 2024
Closed
@Mykhailo-Sichkaruk Mykhailo-Sichkaruk mentioned this pull request Jun 19, 2024
Closed
@JamieVangeysel JamieVangeysel mentioned this pull request Jun 20, 2024
Closed
@malhanpraveen malhanpraveen mentioned this pull request Jun 21, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Jul 26, 2024
Closed
@JamieVangeysel JamieVangeysel mentioned this pull request Aug 2, 2024
Closed
@NicolasTOISON NicolasTOISON mentioned this pull request Aug 7, 2024
Merged
@JamieVangeysel JamieVangeysel mentioned this pull request Aug 11, 2024
Closed
This was referenced Aug 21, 2024
Open
Open
Open
Open
Open
Open
Open
@Jamesp918 Jamesp918 mentioned this pull request Aug 24, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Aug 25, 2024
Closed
This was referenced Aug 28, 2024
Open
Open
This was referenced Sep 3, 2024
Closed
Closed
This was referenced Sep 8, 2024
Open
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Sep 10, 2024
Closed
@WesleyR10 WesleyR10 mentioned this pull request Sep 12, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Sep 18, 2024
Closed
@Jamesp918 Jamesp918 mentioned this pull request Sep 18, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Sep 24, 2024
Closed
@Jamesp918 Jamesp918 mentioned this pull request Sep 25, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Sep 27, 2024
Closed
@Jamesp918 Jamesp918 mentioned this pull request Oct 15, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Oct 27, 2024
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 22, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

@Fdawgs Fdawgs Fdawgs approved these changes

Assignees

No one assigned

Labels

github actions Github actions related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gurgunday @Uzlopak @Fdawgs