Skip to content

fix: Extend tap with .test.mjs tests & Rename existing ESM test#5391

Merged
mcollina merged 2 commits intofastify:mainfrom
melroy89:rename_esm_test_filename
Apr 8, 2024
Merged

fix: Extend tap with .test.mjs tests & Rename existing ESM test#5391
mcollina merged 2 commits intofastify:mainfrom
melroy89:rename_esm_test_filename

Conversation

@melroy89
Copy link
Copy Markdown
Contributor

@melroy89 melroy89 commented Apr 8, 2024 •
edited
Loading

  • Extending .taprc with .test.mjs files (I thought I already did? but not commited I guess).
  • Rename one other ESM test from esm.mjs to esm.test.mjs, so that test also gets executed during npm test (tap). As well as my new errorCodes.test.mjs test.

Follow-up from previous PR: #5390

Suites:   ​169 passed​, ​169 of 169 completed
Asserts:  ​​​8315 passed​, ​5 skip​, ​of 8320

Checklist

@melroy89 melroy89 changed the title Fix: Extend tap with .test.mjs tests & Rename existing ESM test fix: Extend tap with .test.mjs tests & Rename existing ESM test Apr 8, 2024
mcollina
mcollina approved these changes Apr 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 4a35a5a into fastify:main Apr 8, 2024
@melroy89 melroy89 deleted the rename_esm_test_filename branch April 8, 2024 09:10
@urbankrepel urbankrepel mentioned this pull request May 28, 2024
Merged
@Viorel1989 Viorel1989 mentioned this pull request May 28, 2024
Merged
@raniellimontagna raniellimontagna mentioned this pull request May 28, 2024
Closed
@denbon05 denbon05 mentioned this pull request May 28, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request May 29, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request May 29, 2024
Closed
@bryopsida bryopsida mentioned this pull request May 29, 2024
Merged
This was referenced May 30, 2024
Closed
Open
This was referenced Jun 1, 2024
Closed
Closed
@lholmquist lholmquist mentioned this pull request Jun 5, 2024
Closed
This was referenced Jun 5, 2024
Closed
Closed
Closed
@JamieVangeysel JamieVangeysel mentioned this pull request Jun 12, 2024
Closed
@densbozz densbozz mentioned this pull request Jun 13, 2024
Open
@Mykhailo-Sichkaruk Mykhailo-Sichkaruk mentioned this pull request Jun 14, 2024
Closed
@YuraGB YuraGB mentioned this pull request Jun 14, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Jun 14, 2024
Closed
@Mykhailo-Sichkaruk Mykhailo-Sichkaruk mentioned this pull request Jun 19, 2024
Closed
@JamieVangeysel JamieVangeysel mentioned this pull request Jun 20, 2024
Closed
@malhanpraveen malhanpraveen mentioned this pull request Jun 21, 2024
Open
@NicolasTOISON NicolasTOISON mentioned this pull request Jun 27, 2024
Merged
@JamieVangeysel JamieVangeysel mentioned this pull request Jul 26, 2024
Closed
@JamieVangeysel JamieVangeysel mentioned this pull request Aug 2, 2024
Closed
@NicolasTOISON NicolasTOISON mentioned this pull request Aug 7, 2024
Merged
@JamieVangeysel JamieVangeysel mentioned this pull request Aug 11, 2024
Closed
This was referenced Aug 21, 2024
Open
Open
Open
Open
Open
Open
Open
@Jamesp918 Jamesp918 mentioned this pull request Aug 24, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Aug 25, 2024
Closed
This was referenced Aug 28, 2024
Open
Open
This was referenced Sep 3, 2024
Closed
Closed
This was referenced Sep 8, 2024
Open
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Sep 10, 2024
Closed
@WesleyR10 WesleyR10 mentioned this pull request Sep 12, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Sep 18, 2024
Closed
@Jamesp918 Jamesp918 mentioned this pull request Sep 18, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Sep 24, 2024
Closed
@Jamesp918 Jamesp918 mentioned this pull request Sep 25, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Sep 27, 2024
Closed
@Jamesp918 Jamesp918 mentioned this pull request Oct 15, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Oct 27, 2024
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mcollina mcollina mcollina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@melroy89 @mcollina