Skip to content

docs(typescript): update example https server#5389

Merged
mcollina merged 3 commits intofastify:mainfrom
Tony133:docs/update-section-typescript-example-https-server
Apr 10, 2024
Merged

docs(typescript): update example https server#5389
mcollina merged 3 commits intofastify:mainfrom
Tony133:docs/update-section-typescript-example-https-server

Conversation

@Tony133
Copy link
Copy Markdown
Member

@Tony133 Tony133 commented Apr 6, 2024

Checklist

Proposal:

  • Updated the tutorial in the "example 2: server HTTPS" in the section on TypeScript

issue: #5387

@Tony133 Tony133 force-pushed the docs/update-section-typescript-example-https-server branch 2 times, most recently from 4ec3b6c to 72ab2c5 Compare April 6, 2024 15:03
Copy link
Copy Markdown
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but better to copy the command inside and remove the link.

@Tony133
Copy link
Copy Markdown
Member Author

Tony133 commented Apr 6, 2024

Good, but better to copy the commend inside and remove the link.

If I understand correctly, we leave the same text but without linking? correct ?

Copy link
Copy Markdown
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @climba03003 comments

@Tony133 Tony133 force-pushed the docs/update-section-typescript-example-https-server branch from 5101ef1 to 6108f64 Compare April 7, 2024 09:41
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@climba03003
Copy link
Copy Markdown
Member

climba03003 commented Apr 7, 2024

You still forgotten the part of copy the commands inside the link to this doc and doing just remove the link.

@Tony133
Copy link
Copy Markdown
Member Author

Tony133 commented Apr 7, 2024

You still forgotten the part of copy the commends inside the link to this doc and doing just remove the link.

@climba03003 I set it up like this:

6108f64

But, i still haven't figured out how you want to layout this part, can you send a change request? so I can see

@climba03003
Copy link
Copy Markdown
Member

climba03003 commented Apr 7, 2024

For what I want is the commend of generating key.pem and cert.pem exists in the document.

The openssl commands is exactly inside the link I provide.

So, people don't need to click the link or rely on external sources to figure out how to do.

@Tony133
Copy link
Copy Markdown
Member Author

Tony133 commented Apr 7, 2024

Perché quello che voglio è l'elogio della generazione key.pemed cert.pemesiste nel documento.

Gli opensslelogi sono esattamente all'interno del collegamento che fornisco.

Pertanto, le persone non hanno bisogno di fare clic sul collegamento o di affidarsi a fonti esterne per capire come farlo.

@climba03003 then we could write something like this:

  1. Follow the steps in the official guide to the Node.js https server
    and create the key.pem and cert.pem files as follows:
openssl genrsa -out key.pem
openssl req -new -key key.pem -out csr.pem
openssl x509 -req -days 9999 -in csr.pem -signkey key.pem -out cert.pem
rm csr.pem

Do you like it like this ?

@climba03003
Copy link
Copy Markdown
Member

Similar, but the wording need to change because there is no official documentation shown anymore.

cc @Fdawgs

@Tony133 Tony133 force-pushed the docs/update-section-typescript-example-https-server branch from 6108f64 to 949774b Compare April 7, 2024 19:51
@Tony133 Tony133 force-pushed the docs/update-section-typescript-example-https-server branch from 949774b to 4d0d2b1 Compare April 7, 2024 19:56
@Tony133
Copy link
Copy Markdown
Member Author

Tony133 commented Apr 7, 2024

I have rephrased the description without reference to the official Node.js documentation, see commit here: 4d0d2b1, please let me know if that will work for you 😉

Have a good week!

@climba03003 climba03003 requested a review from Fdawgs April 8, 2024 10:09
Copy link
Copy Markdown
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will review tomorrow

Tony133 and others added 2 commits April 9, 2024 22:02
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Signed-off-by: Antonio Tripodi <Tony133@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants