docs(typescript): update example https server#5389
Conversation
4ec3b6c to
72ab2c5
Compare
If I understand correctly, we leave the same text but without linking? correct ? |
metcoder95
left a comment
There was a problem hiding this comment.
LGTM with @climba03003 comments
5101ef1 to
6108f64
Compare
|
You still forgotten the part of |
@climba03003 I set it up like this: But, i still haven't figured out how you want to layout this part, can you send a change request? so I can see |
|
For what I want is the commend of generating The So, people don't need to click the link or rely on external sources to figure out how to do. |
@climba03003 then we could write something like this:
openssl genrsa -out key.pem
openssl req -new -key key.pem -out csr.pem
openssl x509 -req -days 9999 -in csr.pem -signkey key.pem -out cert.pem
rm csr.pemDo you like it like this ? |
|
Similar, but the wording need to change because there is no official documentation shown anymore. cc @Fdawgs |
6108f64 to
949774b
Compare
949774b to
4d0d2b1
Compare
|
I have rephrased the description without reference to the official Node.js documentation, see commit here: 4d0d2b1, please let me know if that will work for you 😉 Have a good week! |
Co-authored-by: Frazer Smith <frazer.dev@outlook.com> Signed-off-by: Antonio Tripodi <Tony133@users.noreply.github.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Checklist
npm run testandnpm run benchmarkand the Code of conduct
Proposal:
issue: #5387