fix: remove http version check#4962
fix: remove http version check#4962Uzlopak merged 17 commits intofastify:nextfrom beyazit:http-version-check
Conversation
|
I suspect this is a major version change and should thus target the |
I changed pull request base to |
climba03003
left a comment
There was a problem hiding this comment.
I changed pull request base to next branch.
You need to rebase your changes on top of the next branch, so it would not include all the unnecessary commits.
* fix: FastifySchemaValidationError.params could be unknown * refactor: use FastifySchemaValidationError instead of ValidationResult * fix: export ValidationResult for backword compatibility * test: add non-assignable test for AjvErrorObject
Co-authored-by: Carlos Fuentes <me@metcoder.dev>
* docs: early hints plugin is fastify plugin * fix * Update docs/Guides/Ecosystem.md Co-authored-by: Frazer Smith <frazer.dev@outlook.com> --------- Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
* chore: add pull request title check * Update .github/workflows/pull-request-title.yml Co-authored-by: Frazer Smith <frazer.dev@outlook.com> --------- Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Bumps [@sinclair/typebox](https://github.com/sinclairzx81/typebox) from 0.29.6 to 0.30.2. - [Commits](sinclairzx81/typebox@0.29.6...0.30.2) --- updated-dependencies: - dependency-name: "@sinclair/typebox" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* improve pr title check * Apply suggestions from code review * fix * fix * Update .github/workflows/pull-request-title.yml Co-authored-by: Luis Orbaiceta <luisorbaiceta@gmail.com> * Apply suggestions from code review --------- Co-authored-by: Luis Orbaiceta <luisorbaiceta@gmail.com>
* improve pr title check * Apply suggestions from code review * fix * fix * ci: fix warnings in benchmark workflow * Update .github/workflows/benchmark.yml * Update .github/workflows/benchmark.yml
* docs(Validator Compiler): fix removeAdditional comment * Update docs/Reference/Validation-and-Serialization.md Co-authored-by: Uzlopak <aras.abbasi@googlemail.com> * fix: typo in comment * Update docs/Reference/Validation-and-Serialization.md Co-authored-by: Frazer Smith <frazer.dev@outlook.com> --------- Co-authored-by: Uzlopak <aras.abbasi@googlemail.com> Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
* fix: infer correct hook handler * Update test/types/hooks.test-d.ts * simplify * remove duplicate typing tests * remove duplicate test * remove unused import * fix * fix linting
|
damn, is this correct? i rebased my commits to fastify/next and made a force push |
|
I merged main into next and updated this branch. The commits are still the same ,but a squash merge should fix all the issues. |
|
@climba03003 |
|
Maybe should also remove https://github.com/fastify/fastify/blob/main/docs/Reference/Routes.md#--http-version-check Well, lets say the underlying PR got merged into node code. Is it safe to remove this check already? |
|
I still prefer a clean history even on PR.
Yes
Yes, I have double checked the changes is landed on 16, 18 and 20. |
|
Are you still actively working on this PR? |
|
I guess, @beyazit abandoned this PR. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Checklist
npm run testandnpm run benchmarkand the Code of conduct
Node.js issue #43115 has been resolved so I have removed this check.