Next: Disallow decorate('name', null) in the types#4878
Merged
climba03003 merged 2 commits intofastify:nextfrom Jul 7, 2023
Merged
Next: Disallow decorate('name', null) in the types#4878climba03003 merged 2 commits intofastify:nextfrom
decorate('name', null) in the types#4878climba03003 merged 2 commits intofastify:nextfrom
Conversation
Preferred to use `decorate('name')` , `decorateRequest('name')`, `decorateReply('name')` variants instead
Deprecation not feasible because of microsoft/TypeScript#54872
Follow up to fastify#4874
Signed-off-by: Pelle Wessman <pelle@kodfabrik.se>
4 tasks
suyundukov
approved these changes
Jul 6, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #4874
Preferred to use
decorate('name'),decorateRequest('name'),decorateReply('name')variants insteadDeprecation prior to dropping is not feasible because of microsoft/TypeScript#54872
Checklist
npm run testandnpm run benchmarkand/or benchmarksare includedand the Code of conduct