-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
🌐 Add Korean translation for docs/ko/docs/tutorial/security/oauth2-jwt.md
#13333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Korean translation for docs/ko/docs/tutorial/security/oauth2-jwt.md
#13333
Conversation
|
📝 Docs preview for commit 9a3aa52 at: https://96bcf44e.fastapitiangolo.pages.dev Modified Pages |
docs/ko/docs/tutorial/security/oauth2-jwt.md
|
📝 Docs preview for commit 88f97c0 at: https://2afdda2b.fastapitiangolo.pages.dev Modified Pages |
timothy-jeong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a huge document!
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
|
📝 Docs preview for commit 77d00dc at: https://4b667c2b.fastapitiangolo.pages.dev Modified Pages |
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
|
📝 Docs preview for commit 1bf5364 at: https://c16d5411.fastapitiangolo.pages.dev Modified Pages |
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
|
📝 Docs preview for commit 44a8ba4 at: https://971fd67e.fastapitiangolo.pages.dev Modified Pages |
timothy-jeong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thank you for helping me with my first, inexperienced translation. Thanks to you, I was able to identify several mistranslations. And I had a meaningful time reflecting on them. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi. i left some comment for you.
Here's a tip: when you've written a long sentence, read it out loud to yourself. Then you can find something awkward in yours.
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
|
📝 Docs preview for commit 9145f42 at: https://061ee22e.fastapitiangolo.pages.dev Modified Pages |
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
|
📝 Docs preview for commit 2c27712 at: https://1fd3cf24.fastapitiangolo.pages.dev Modified Pages |
|
📝 Docs preview for commit 5db68e9 at: https://f139774c.fastapitiangolo.pages.dev Modified Pages |
안녕하세요. 친절하게 도움 주셔서 감사합니다. 제안 주신 내용을 그대로 수용한 경우 resolved 로 변경하였고, |
sodaMelon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @yes0ng 👍
sorry for late response im stuck irl
문장이 훨씬 좋아졌네요!! 승인 늦어서 죄송해요ㅠㅠ 고생하셨습니다!
덕분에 많이 배웠습니다! 꼼꼼히 봐주셔서 감사합니다 🙏 |
|
Thank you for your contribution! @yes0ng 🚀 |
Hello! This is my first translation, so it may be lacking a lot.
If there are any Korean translation guidelines in this repo, please let me know.I found discussion(#3167) late and corrected it a little more.
I would greatly appreciate any feedback 🙇♀️
✏️ Note
1️⃣ There is some paraphrasing. Some sentences have been reconstructed to a level that is easy for Koreans to read without damaging the meaning of the original text. (I think that simple word translations could be handled well by browser translation features.)
2️⃣ For consistency within the security subdocuments, I translated "password" into "패스워드" according to the
simple-oauth2.md, instead of "비밀번호"