Skip to content

Conversation

@k94-ishi
Copy link
Contributor

@k94-ishi k94-ishi commented Feb 4, 2025

This PR is a translation of docs/ja/docs/tutorial/query-param-models.md. I'm Japanese.

@github-actions github-actions bot added the lang-all Translations label Feb 4, 2025
@alejsdev alejsdev added lang-ja Japanese translations awaiting-review labels Feb 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Copy link
Contributor

@maru0123-2004 maru0123-2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your translating!
I think there are no problems have to fix, so I approve this.
(Note: If you change "Pydanticのモデルのconfiguration" in #13330 , please change here, too. Sorry for your hard work.)

Copy link

@J-Fuji J-Fuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your good job!

@github-actions
Copy link
Contributor

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also double-checked the overal structure and that looks good 👍

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @k94-ishi! 🥮

And thanks all for the reviews ☕

@tiangolo tiangolo merged commit 2cf2fee into fastapi:master Feb 28, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ja Japanese translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants