🔥 Remove Sentry link from Advanced Middleware docs#12031
Merged
Conversation
Contributor
|
📝 Docs preview for commit 8a2ce63 at: https://aab1cfa7.fastapitiangolo.pages.dev Modified Pages |
Member
|
Great, thanks! 🤓 🍰 |
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Aug 17, 2024
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Sep 12, 2024
s-rigaud
pushed a commit
to s-rigaud/fastapi
that referenced
this pull request
Jan 23, 2025
smeubank
added a commit
to smeubank/fastapi
that referenced
this pull request
Mar 5, 2025
With a previous PR Sentry was removed from middleware section, which I believe was the write decision. fastapi#12031 Similar to other frameworks, it makes more sense in an error handling section. Long term it might be interesting to have something observability more generically, and not specific to Sentry. Logs, spans, and metrics. How different tools can help developers gain more insights in their code and debug faster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 Remove Sentry link from Advanced Middleware docs
As this is in the section about middlewares and the new integration is not really a middleware, better to remove it from this page.
We should probably add it later to another section. 🤔