📝 Highlight correct line in tutorial docs/en/docs/tutorial/body-multiple-params.md#11978
Merged
tiangolo merged 2 commits intofastapi:masterfrom Aug 17, 2024
Merged
📝 Highlight correct line in tutorial docs/en/docs/tutorial/body-multiple-params.md#11978tiangolo merged 2 commits intofastapi:masterfrom
docs/en/docs/tutorial/body-multiple-params.md#11978tiangolo merged 2 commits intofastapi:masterfrom
Conversation
Contributor
|
📝 Docs preview for commit 543943a at: https://f345e146.fastapitiangolo.pages.dev Modified Pages |
Contributor
|
📝 Docs preview for commit 4b196d8 at: https://96f089ae.fastapitiangolo.pages.dev Modified Pages |
docs/en/docs/tutorial/body-multiple-params.md
Member
|
Great, thank you! 🙇 |
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Aug 17, 2024
…iple-params.md` (fastapi#11978) Co-authored-by: Esteban Maya <emayacadavid9@gmail.com>
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Sep 12, 2024
…iple-params.md` (fastapi#11978) Co-authored-by: Esteban Maya <emayacadavid9@gmail.com>
s-rigaud
pushed a commit
to s-rigaud/fastapi
that referenced
this pull request
Jan 23, 2025
…iple-params.md` (fastapi#11978) Co-authored-by: Esteban Maya <emayacadavid9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tutorial section https://fastapi.tiangolo.com/tutorial/body-multiple-params/#multiple-body-params-and-query is about adding query parameters on top of (several) body parameters. In the sections before it, the tutorial had introduced 3 body parameters:
item,userandimportance. This section then focuses on adding the query parameterq, so it seems to me like the next line should be highlighted in the code snippets - the line definingqinstead of the one definingimportance.Or, alternatively, we could highlight all 4 lines (the 3 body parameters + the additional query parameter)