Skip to content

🐛 Fix allow_inf_nan option for Param and Body classes#11867

Merged
tiangolo merged 9 commits intofastapi:masterfrom
giunio-prc:fix/issue11580
Aug 24, 2024
Merged

🐛 Fix allow_inf_nan option for Param and Body classes#11867
tiangolo merged 9 commits intofastapi:masterfrom
giunio-prc:fix/issue11580

Conversation

@giunio-prc
Copy link
Copy Markdown
Contributor

@giunio-prc giunio-prc commented Jul 19, 2024 •
edited
Loading

adjust typo causing allow_inf_nan to be ignored during paramter enforcing

I added the test from the issue page #11580 in a separate commit

@giunio-prc giunio-prc mentioned this pull request Jul 19, 2024
Closed
9 tasks
@giunio-prc giunio-prc changed the title Fix/issue11580 Fix/issue11580 allow_nan_inf ignored when enforcing parameters Jul 19, 2024
@giunio-prc giunio-prc changed the title Fix/issue11580 allow_nan_inf ignored when enforcing parameters Fix/issue11580 allow_inf_nan ignored when enforcing parameters Jul 19, 2024
@YuriiMotov
Copy link
Copy Markdown
Member

YuriiMotov commented Jul 19, 2024

Duplicates existing PR: https://github.com/tiangolo/fastapi/pull/11579/files

@giunio-prc
Copy link
Copy Markdown
Contributor Author

giunio-prc commented Jul 19, 2024

Duplicates existing PR: https://github.com/tiangolo/fastapi/pull/11579/files

I see, but that one is missing one occurence, the problem happens for Params and Body class

@giunio-prc giunio-prc marked this pull request as draft July 19, 2024 21:17
@giunio-prc giunio-prc marked this pull request as ready for review July 21, 2024 07:19
@alejsdev alejsdev added the bug Something isn't working label Jul 24, 2024
@svlandeg svlandeg self-assigned this Aug 19, 2024
@svlandeg svlandeg changed the title Fix/issue11580 allow_inf_nan ignored when enforcing parameters 🐛 Fix allow_inf_nan options for Param and Body classes Aug 19, 2024
@svlandeg svlandeg changed the title 🐛 Fix allow_inf_nan options for Param and Body classes 🐛 Fix allow_inf_nan option for Param and Body classes Aug 19, 2024
@svlandeg svlandeg linked an issue Aug 19, 2024 that may be closed by this pull request
Query fields with numeric types appear not to enforce allow_inf_nan=False, whereas gt=0, etc are enforced #11580
Closed
9 tasks
@svlandeg svlandeg mentioned this pull request Aug 19, 2024
Closed
svlandeg
svlandeg approved these changes Aug 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@svlandeg svlandeg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @giunio-prc for the contribution, and @YuriiMotov for the review and link to the related PR 🙏

I can confirm that this bug occurs on master and should be fixed with this PR. In addition to the fix in the original PR #11579, this one also fixes a similar issue with Body, so I would prefer to merge this one and close the other. I've updated the unit tests here to include the cases from both PRs, I added parametrization and updated the PR with the latest from master. Thanks to @pat-lasswell as well for the original report and PR! 🎉

@svlandeg svlandeg removed their assignment Aug 19, 2024
@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Aug 24, 2024

Thanks for your contribution @giunio-prc! 🍰

Thanks for the extra info @YuriiMotov 🍫

And thanks for the help and tweaks @svlandeg! 🙇

This will be available in FastAPI 0.112.2 released in the next hours. 🎉

@tiangolo tiangolo merged commit 51b625e into fastapi:master Aug 24, 2024
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
@giunio-prc @pre-commit-ci
@svlandeg @black-redoc
🐛 Fix allow_inf_nan option for Param and Body classes (fastapi#11867)
0edc14e 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: svlandeg <svlandeg@github.com>
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
@giunio-prc @pre-commit-ci
@svlandeg @black-redoc
🐛 Fix allow_inf_nan option for Param and Body classes (fastapi#11867)
6be31da 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: svlandeg <svlandeg@github.com>
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
@giunio-prc @pre-commit-ci
@svlandeg @black-redoc
🐛 Fix allow_inf_nan option for Param and Body classes (fastapi#11867)
0dd73d1 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: svlandeg <svlandeg@github.com>
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
@giunio-prc @pre-commit-ci
@svlandeg @s-rigaud
🐛 Fix allow_inf_nan option for Param and Body classes (fastapi#11867)
dec8e26 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: svlandeg <svlandeg@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svlandeg svlandeg svlandeg approved these changes

+1 more reviewer

@NischalSehrawat NischalSehrawat NischalSehrawat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Query fields with numeric types appear not to enforce allow_inf_nan=False, whereas gt=0, etc are enforced

6 participants

@giunio-prc @YuriiMotov @tiangolo @svlandeg @NischalSehrawat @alejsdev