🔨 Specify email-validator dependency with dash#11515
🔨 Specify email-validator dependency with dash#11515tiangolo merged 4 commits intofastapi:masterfrom
email-validator dependency with dash#11515Conversation
email-validator with dash
email-validator with dashemail-validator dependency with dash
|
📝 Docs preview for commit 6e867de at: https://8841bcea.fastapitiangolo.pages.dev |
|
It seems that after deeper investigation, the metadata for the |
There was a problem hiding this comment.
It makes sense to me to change the references in the documentation to email-validator, especially considering this edit.
As a note, this PR also changes the pyproject.toml but I think that should be OK as well. For what it's worth, Pydantic also uses email-validator in their project.toml.
It looks like some tests are failing after running the CI after merging in the latest master. These failing tests seem unrelated to me, but I'll keep this in draft and may come back to rerun the tests again next week (in case this is just a Github issue).
[UPDATE]: investigating the CI issue separately here.
[UPDATE 2]: The CI issues are now fixed to this PR should be ready to merge (after a final check by Tiangolo)
|
Thanks @jirikuncar! And thanks @svlandeg for the investigation and review 🙇 |
Co-authored-by: svlandeg <svlandeg@github.com>
Co-authored-by: svlandeg <svlandeg@github.com>
Co-authored-by: svlandeg <svlandeg@github.com>
The package name is
email-validator.This is more of a consistency improvement. I noticed after updating to the latest release that transitive dependencies have been renamed.