fix: Fallback to file modified time if file created time is invalid when rolling#142
Merged
fix: Fallback to file modified time if file created time is invalid when rolling#142
Conversation
Contributor
Author
|
PTAL @tisonkun . Could you help review this? |
tisonkun
approved these changes
Jul 9, 2025
Contributor
tisonkun
left a comment
There was a problem hiding this comment.
Good to go.
Although, as stated at zuston/riffle#366 (comment), it's possible to implement a sort strategy based on the count suffix.
I'd leave it as a nice-to-have follow-up since the current strategy can handle most cases already.
Contributor
Author
Thanks tison. Could you help release a new version? |
Contributor
|
Sure. Let me handle it today .. |
Contributor
|
@zuston Released 0.26.2 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for zuston/riffle#366