Closed
Conversation
Contributor
|
@yangdanny97 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92566912. |
yangdanny97
added a commit
to yangdanny97/pyrefly
that referenced
this pull request
Feb 6, 2026
Summary: Pull Request resolved: facebook#2348 Differential Revision: D92566912
e2fd2f1 to
cb972e9
Compare
This comment has been minimized.
This comment has been minimized.
yangdanny97
added a commit
to yangdanny97/pyrefly
that referenced
this pull request
Feb 7, 2026
Summary: Pull Request resolved: facebook#2348 Differential Revision: D92566912
cb972e9 to
815dc8a
Compare
This comment has been minimized.
This comment has been minimized.
stroxler
approved these changes
Feb 7, 2026
Contributor
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
stroxler
requested changes
Feb 7, 2026
Contributor
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: If a tuple literal has no contextual type & has >256 elements, we infer `tuple[Any, ...]` Differential Revision: D92566912
815dc8a to
21e469e
Compare
stroxler
approved these changes
Feb 8, 2026
Contributor
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
This pull request has been merged in b1fe95d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D92566912