[lexical-history] Feature: Add maxDepth option to HistoryExtension#8537
Merged
Conversation
Adds a maxDepth: number | null config option (and matching output Signal) to HistoryExtension. When non-null, the undo stack is FIFO-evicted to that length on each push. Defaults to null, preserving the historical unbounded behavior — existing consumers are unchanged. This is intentionally a per-event check rather than a periodic prune so the cap is enforced exactly when entries are appended; the trim does shape the array referenced by `historyState.undoStack` (in place via splice) so peer extensions such as SharedHistoryExtension that hold a reference to it continue to see the trimmed stack. Tests cover three cases: the unbounded default, a finite cap evicting older entries, and reactive lowering of the cap via the output Signal.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zurfyx
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
maxDepth: number | nullconfig option (and matching output Signal) toHistoryExtension. When non-null, the undo stack is FIFO-evicted to that length on each push. Defaults to null, preserving the historical unbounded behavior — existing consumers are unchanged.This is intentionally a per-event check rather than a periodic prune so the cap is enforced exactly when entries are appended; the trim does shape the array referenced by
historyState.undoStack(in place via splice) so peer extensions such asSharedHistoryExtensionthat hold a reference to it continue to see the trimmed stack.Test plan
New unit tests cover three cases: the unbounded default, a finite cap evicting older entries, and reactive lowering of the cap via the output Signal.