[lexical-code-core] Bug Fix: detect nested br elements in pasted code#8487
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
May 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes multiline code detection during HTML import when a
<br>is nested inside inline markup within a<code>element.CodeNode.importDOM()already treats multiline<code>content as a code block, but the recursivehasChildDOMNodeTag()helper did not return recursive matches. As a result, markup such as<code><span>1<br>2</span></code>could be imported as inline code instead of a code block.This updates the helper to return nested matches and adds regression coverage for the nested
<br>case.Test Plan
pnpm.cmd exec vitest --project unit packages/lexical/src/__tests__/unit/CodeBlock.test.ts --run