[lexical][lexical-list] Feature: Add $setFormatFromDOM function and use it to import alignment for ListItem#8460
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
reviewed
May 3, 2026
etrepum
left a comment
Collaborator
There was a problem hiding this comment.
It would be good to introduce a $setFormatFromDOM helper here since this isn't the only place that does this check, also a unit test to confirm that it's doing the right thing (round-tripping alignment) would be good.
63187ee to
4c5a211
Compare
$setFormatFromDOM function and use it to import alignment for ListItem
Contributor
Author
|
I added a couple of tests and also took into account the handling of inserting a list from Google Docs |
etrepum
reviewed
May 3, 2026
etrepum
reviewed
May 5, 2026
382d012 to
3297cff
Compare
etrepum
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A new util function
$setFormatFromDOMhas been added to the lexical and is used in all provided nodes to set format alignment during importDOMMost elements provided by lexical set their alignment during HTML export and set the relevant format if alignment is present during importDOM. For list elements, alignment was lost importDOM; this PR fixes that
Closes #4243
Test plan
Before
Screen.Recording.2026-05-03.at.23.02.19.mov
After
Screen.Recording.2026-05-03.at.23.03.25.mov